REF: remove libreduction.SeriesGrouper #43505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 11, 2021
| @@ -811,7 +811,7 @@ def test_categoricals(a_dtype, b_dtype): | |||
| a_is_cat = is_categorical_dtype(a.dtype) | |||
| assert not a_is_cat or a.value_counts().loc[1] == 0 | |||
| result = crosstab(a, b, margins=True, dropna=False) | |||
| values = [[18, 16, 34], [0, 0, np.nan], [34, 32, 66], [52, 48, 100]] | |||
| values = [[18, 16, 34], [0, 0, 0], [34, 32, 66], [52, 48, 100]] | |||
There was a problem hiding this comment.
may want to add a note for this (i agree that this looks more correct)
2 tasks
|
I agree that this looks like a bug fix too. |
|
@bashtage can i pawn off the writing of a whatsnew on you? i have zero experience with crosstab |
2 tasks
bashtage
added a commit
to bashtage/pandas
that referenced
this pull request
Sep 13, 2021
|
What's new in #43548 |
jreback
pushed a commit
that referenced
this pull request
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bashtage per comment #37468 (comment) I'm taking your word for it that the change this makes in the crosstab test is correct. Does this represent a bugfix?