Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Series[object].unstack preserve object dtype #44595

Merged
merged 5 commits into from
Nov 24, 2021

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 23, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Sits on top of #44593

@jreback
Copy link
Contributor

jreback commented Nov 24, 2021

looks good if u can add a whatsnew

@jreback jreback added this to the 1.4 milestone Nov 24, 2021
@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 24, 2021
@jreback jreback merged commit 8374c65 into pandas-dev:master Nov 24, 2021
@jbrockmendel jbrockmendel deleted the bug-unstack-object branch November 24, 2021 18:39
@TomAugspurger
Copy link
Contributor

@jbrockmendel can you confirm whether the slowdown in https://pandas.pydata.org/speed/pandas/#reshape.ReshapeExtensionDtype.time_transpose?python=3.8&Cython=0.29.24&p-dtype='datetime64%5Bns%2C%20US%2FPacific%5D'&commits=8374c656 pointing to this is expected? I think it is, but wanted to confirm.

@jbrockmendel
Copy link
Member Author

can you confirm whether the slowdown in https://pandas.pydata.org/speed/pandas/#reshape.ReshapeExtensionDtype.time_transpose?python=3.8&Cython=0.29.24&p-dtype='datetime64%5Bns%2C%20US%2FPacific%5D'&commits=8374c656 pointing to this is expected? I think it is, but wanted to confirm.

No. I don't see how this would affect DataFrame.transpose. More plausibly #44593 which this sits on top of? Even then I'd need to take a look bc I did not expect that to hurt perf.

@jbrockmendel
Copy link
Member Author

OK I think #44593 caused us to split a 2D DatetimeArray into column arrays, which would account for the slowdown, but is not intended. Will look into a fix.

@jbrockmendel
Copy link
Member Author

Perf regression fixed in #44724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants