Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: should constructors check and raise if big-endian dtypes are detected? #4737

Open
jreback opened this issue Sep 3, 2013 · 6 comments
Open
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Enhancement Error Reporting Incorrect or improved errors from pandas

Comments

@jreback
Copy link
Contributor

jreback commented Sep 3, 2013

related #2330, #2821

pretty easy to do; doesn't really take much time either (can be done in the block manager)

http://stackoverflow.com/questions/18599579/python-pandas-multi-index

could also easily convert them (which in theory could be expensive so should be a method)

@shoyer
Copy link
Member

shoyer commented Apr 26, 2015

This seems to come up with some frequency when dealing with data converted from binary file formats like FITS or netCDF.

I think we should definitely handle this automatically -- or provide some sort of constructor that allows for opting in to handling this automatically. It's not very user friendly to need to manually check types and do a byteswap before passing data in.

CC @astrofrog

@embray
Copy link
Contributor

embray commented May 4, 2015

I agree--I don't see the big deal to doing this automatically (except that it's not that common a case for most users and so working on a patch for this would be low priority which I can certainly relate to ;)

MHC03 added a commit to MHC03/pandas that referenced this issue Aug 13, 2018
@jbrockmendel jbrockmendel added the Constructors Series/DataFrame/Index/pd.array Constructors label Jul 23, 2019
@mroeschke mroeschke added Enhancement Dtype Conversions Unexpected or buggy dtype conversions labels Apr 27, 2020
@mroeschke mroeschke removed the Internals Related to non-user accessible pandas implementation label Apr 11, 2021
@elehcim
Copy link

elehcim commented Mar 24, 2022

Any news on this?

@jreback
Copy link
Contributor Author

jreback commented Mar 24, 2022

@elehcim pandas would accept a community pull request

core can provide review

@musicinmybrain
Copy link
Contributor

Does this imply that Pandas would like to support only little-endian hosts and little-endian data?

On Fedora Linux, big-endian s390x is a primary architecture. I’ve been working to incrementally update the package and to start running the tests in the RPM build, and at least for Pandas 1.3.5, all but a few of the tests currently do pass on s390x. I probably shouldn’t bother with a PR to improve the endian-independence of the tests if big-endian platforms are going to be explicitly excluded…

@jreback
Copy link
Contributor Author

jreback commented Apr 6, 2022

would accept patches for big end ian

but we have 0 testing so cant officially support

@mroeschke mroeschke removed this from the Someday milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Constructors Series/DataFrame/Index/pd.array Constructors Dtype Conversions Unexpected or buggy dtype conversions Enhancement Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants