Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: MultiIndex.symmetric_difference not keeping ea dtype #48607

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 17, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.
       before           after         ratio
     [b5632fb3]       [811faf6b]
     <deprecation_notes~1>       <sym_diff>
-     16.0±0.09ms      11.0±0.08ms     0.69  multiindex_object.SetOperations.time_operation('monotonic', 'string', 'symmetric_difference')
-      16.4±0.4ms       10.9±0.1ms     0.66  multiindex_object.SetOperations.time_operation('non_monotonic', 'string', 'symmetric_difference')
-      15.2±0.4ms       9.78±0.2ms     0.64  multiindex_object.SetOperations.time_operation('non_monotonic', 'int', 'symmetric_difference')
-      15.8±0.1ms       10.1±0.2ms     0.64  multiindex_object.SetOperations.time_operation('non_monotonic', 'datetime', 'symmetric_difference')
-      15.1±0.1ms      9.40±0.08ms     0.62  multiindex_object.SetOperations.time_operation('monotonic', 'int', 'symmetric_difference')
-      15.8±0.1ms      9.79±0.04ms     0.62  multiindex_object.SetOperations.time_operation('monotonic', 'datetime', 'symmetric_difference')

@phofl phofl added MultiIndex NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Sep 17, 2022
@mroeschke mroeschke added this to the 1.6 milestone Sep 19, 2022
@mroeschke mroeschke merged commit 1ac2675 into pandas-dev:main Sep 19, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the sym_diff branch September 20, 2022 08:23
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
…#48607)

* BUG: MultiIndex.symmetric_difference not keeping ea dtype

* Add tests and whatsnew

* Add gh ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MultiIndex NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants