Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some of pandas.io.tests.test_html.TestReadHtml should be conditioned on presence of lxml #5150

Closed
yarikoptic opened this issue Oct 8, 2013 · 7 comments · Fixed by #5151

Comments

@yarikoptic
Copy link
Contributor

commented Oct 8, 2013

Testing on my local armel box (heh -- bringing now my own media box into the game): it seems to avoid #4473 but whines about

======================================================================
ERROR: test_parse_dates_combine (pandas.io.tests.test_html.TestReadHtml)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/tests/test_html.py", line 580, in test_parse_dates_combine
    index_col=1)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 840, in read_html
    parse_dates, tupleize_cols, thousands, attrs)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 698, in _parse
    parser = _parser_dispatch(flav)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 657, in _parser_dispatch
    raise ImportError("lxml not found please install it")
ImportError: lxml not found please install it

======================================================================
ERROR: test_parse_dates_list (pandas.io.tests.test_html.TestReadHtml)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/tests/test_html.py", line 572, in test_parse_dates_list
    res = read_html(expected, parse_dates=[0], index_col=0)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 840, in read_html
    parse_dates, tupleize_cols, thousands, attrs)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 698, in _parse
    parser = _parser_dispatch(flav)
  File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 657, in _parser_dispatch
    raise ImportError("lxml not found please install it")
ImportError: lxml not found please install it
@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 8, 2013

oh shucks forgot to put in the skipping

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2013

Good catch, we will fix it. Seems like we've hit issues with not checking
for deps quite a bit recently.
On Oct 7, 2013 10:47 PM, "Yaroslav Halchenko" notifications@github.com
wrote:

Testing on my local armel box (heh -- bringing now my own media box into
the game): it seems to avoid #4473https://github.com/pydata/pandas/issues/4473but whines about

ERROR: test_parse_dates_combine (pandas.io.tests.test_html.TestReadHtml)

Traceback (most recent call last):
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/tests/test_html.py", line 580, in test_parse_dates_combine
index_col=1)
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 840, in read_html
parse_dates, tupleize_cols, thousands, attrs)
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 698, in _parse
parser = _parser_dispatch(flav)
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 657, in _parser_dispatch
raise ImportError("lxml not found please install it")
ImportError: lxml not found please install it

ERROR: test_parse_dates_list (pandas.io.tests.test_html.TestReadHtml)

Traceback (most recent call last):
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/tests/test_html.py", line 572, in test_parse_dates_list
res = read_html(expected, parse_dates=[0], index_col=0)
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 840, in read_html
parse_dates, tupleize_cols, thousands, attrs)
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 698, in _parse
parser = _parser_dispatch(flav)
File "/home/yoh/deb/gits/pkg-exppsy/pandas/pandas/io/html.py", line 657, in _parser_dispatch
raise ImportError("lxml not found please install it")
ImportError: lxml not found please install it


Reply to this email directly or view it on GitHubhttps://github.com//issues/5150
.

@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 8, 2013

@yarikoptic can you show ci/print_versions.py? i can't reproduce this error even when i uninstall everything

@ghost ghost assigned cpcloud Oct 8, 2013

@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 8, 2013

oh i know what the issue is envm

@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 8, 2013

yep what i thought ... PR on the way!

@cpcloud

This comment has been minimized.

Copy link
Member

commented Oct 8, 2013

was actually just a missing self!

@jtratner

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2013

(and last checking for deps issue I introduced)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.