Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: EA.ffill/bfill? #53621

Closed
jbrockmendel opened this issue Jun 12, 2023 · 0 comments · Fixed by #54001
Closed

API: EA.ffill/bfill? #53621

jbrockmendel opened this issue Jun 12, 2023 · 0 comments · Fixed by #54001
Labels
API Design ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate

Comments

@jbrockmendel
Copy link
Member

jbrockmendel commented Jun 12, 2023 •
edited

ATM EA.fillna handles both a) fillna(scalar), b) ffill/bfill, and c) interpolate (which is mostly broken except for ffill/bfill (which I think should not go through interpolate xref #53581) xref #50950)

At the NDFrame level we have four separate methods: ffill, bfill, fillna, interpolate. I think it makes sense to just have the same four methods all the way down the stack (Manager, Block, EA). I'd also be OK with ffill/bfill being combined into e.g. pad_or_backfill for the internal classes.
@jbrockmendel jbrockmendel added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 12, 2023
@lithomas1 lithomas1 added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate API Design ExtensionArray Extending pandas with custom dtypes or arrays. and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 12, 2023
@jbrockmendel jbrockmendel mentioned this issue Jun 24, 2023
Merged
This was referenced Jul 3, 2023
Merged
Merged
@jorisvandenbossche jorisvandenbossche mentioned this issue Aug 28, 2023
Closed
@rhshadrach rhshadrach mentioned this issue Mar 24, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Design ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: implement EA.pad_or_backfill jbrockmendel/pandas
2 participants
@jbrockmendel @lithomas1