CLN: Enforce deprecations for EA.fillna #57983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Ref: #53621
Ran into a little trouble here -
NDFrame.fillna
has alimit
argument that wasn't deprecated and works, butEA.fillna
has this deprecated and is currently ignored. Currently this PR keeps thelimit
argument inEA.fillna
and removes the deprecation, but the implementation still ignores it. If we want to keep it, I plan on doing a followup implementinglimit
across all EAs (I think this should be straightforward except for maybe Sparse - not sure).As an alternative, we could also deprecate
limit
onNDFrame.fillna
(not my preference), and then I can keep but not enforce the deprecation onEA.fillna
here.cc @jbrockmendel