Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Enforce deprecations for EA.fillna #57983

Merged
merged 1 commit into from Mar 25, 2024

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Mar 24, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Ref: #53621

Ran into a little trouble here - NDFrame.fillna has a limit argument that wasn't deprecated and works, but EA.fillna has this deprecated and is currently ignored. Currently this PR keeps the limit argument in EA.fillna and removes the deprecation, but the implementation still ignores it. If we want to keep it, I plan on doing a followup implementing limit across all EAs (I think this should be straightforward except for maybe Sparse - not sure).

As an alternative, we could also deprecate limit on NDFrame.fillna (not my preference), and then I can keep but not enforce the deprecation on EA.fillna here.

cc @jbrockmendel

@rhshadrach rhshadrach added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Clean ExtensionArray Extending pandas with custom dtypes or arrays. labels Mar 24, 2024
@phofl
Copy link
Member

phofl commented Mar 24, 2024

keeping the limit argument sounds good to me, feel free to merge when ready

@phofl phofl added this to the 3.0 milestone Mar 24, 2024
@mroeschke mroeschke merged commit cd0a4e6 into pandas-dev:main Mar 25, 2024
54 of 56 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the cln_ea_fillna_depr branch March 25, 2024 20:35
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean ExtensionArray Extending pandas with custom dtypes or arrays. Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants