Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame.groupby.count with arrow dtypes do not return arrow dtypes #53831

Closed
2 of 3 tasks
wirable23 opened this issue Jun 24, 2023 · 5 comments · Fixed by #54129
Closed
2 of 3 tasks

BUG: DataFrame.groupby.count with arrow dtypes do not return arrow dtypes #53831

wirable23 opened this issue Jun 24, 2023 · 5 comments · Fixed by #54129
Labels
Arrow pyarrow functionality Bug Dtype Conversions Unexpected or buggy dtype conversions Groupby NA - MaskedArrays Related to pd.NA and nullable extension arrays

Comments

@wirable23
Copy link

wirable23 commented Jun 24, 2023

Pandas version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • I have confirmed this bug exists on the main branch of pandas.

Reproducible Example

>>> df = pd.DataFrame({"A": pd.Series([True, False, True, False], dtype="bool[pyarrow]"), "B": pd.Series([1,2,3,4], dtype="uint64[pyarrow]")})
>>> df.groupby("A").count().dtypes
B    int64
dtype: object
>>> df.groupby("A").std().dtypes
B    float64
dtype: object
>>>

Issue Description

Numpy types were returned when arrow types were provided to groupby.std()/count()

Expected Behavior

I would expect this to return "int64[pyarrow]" and "float64[pyarrow]". Other vectorized aggs such as var, sum, max, min return arrow dtypes when input is arrow backed.

Installed Versions

INSTALLED VERSIONS

commit : 965ceca
python : 3.11.2.final.0
python-bits : 64
OS : Windows
OS-release : 10
Version : 10.0.22621
machine : AMD64
processor : Intel64 Family 6 Model 140 Stepping 1, GenuineIntel
byteorder : little
LC_ALL : None
LANG : None
LOCALE : English_United States.1252

pandas : 2.0.2
numpy : 1.24.3
pytz : 2023.3
dateutil : 2.8.2
setuptools : 65.5.0
pip : 22.3.1
Cython : None
pytest : None
hypothesis : None
sphinx : None
blosc : None
feather : None
xlsxwriter : None
lxml.etree : None
html5lib : None
pymysql : None
psycopg2 : None
jinja2 : None
IPython : None
pandas_datareader: None
bs4 : None
bottleneck : None
brotli : None
fastparquet : None
fsspec : None
gcsfs : None
matplotlib : None
numba : None
numexpr : None
odfpy : None
openpyxl : None
pandas_gbq : None
pyarrow : 12.0.1
pyreadstat : None
pyxlsb : None
s3fs : None
scipy : None
snappy : None
sqlalchemy : None
tables : None
tabulate : None
xarray : None
xlrd : None
zstandard : None
tzdata : 2023.3
qtpy : None
pyqt5 : None

@wirable23 wirable23 added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 24, 2023
@wirable23
Copy link
Author

wirable23 commented Jun 24, 2023

Another weird example:

>>> pd.DataFrame({"A": pd.Series([True, False, True, False], dtype="bool[pyarrow]"), "B": pd.Series([17, 23, 106, 129], dtype="int64[pyarrow]")}).groupby("A").var().dtypes
B    float64
dtype: object
>>> pd.DataFrame({"A": pd.Series([True, False, True, False], dtype="bool[pyarrow]"), "B": pd.Series([17, 23, 107, 129], dtype="int64[pyarrow]")}).groupby("A").var().dtypes
B    int64[pyarrow]
dtype: object
>>>

Changing 3rd value in column B from 106 to 107 causes dtype of var to change from int64[pyarrow] to float64. Var should probably always return a floating type, in this case, "float64[pyarrow]"

@rhshadrach
Copy link
Member

Thanks for the report. All instances except count return pyarrow dtypes on main. size also has the same issue.

@rhshadrach rhshadrach added Groupby Dtype Conversions Unexpected or buggy dtype conversions Arrow pyarrow functionality and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 25, 2023
@wirable23
Copy link
Author

Thanks! Count would be expected to return "int64[pyarrow]"?

@mroeschke mroeschke changed the title BUG: DataFrame.groupby.count/std with arrow dtypes do not return arrow dtypes BUG: DataFrame.groupby.count with arrow dtypes do not return arrow dtypes Jun 29, 2023
@mroeschke
Copy link
Member

This is also an issue for the numpy masked types too

In [4]: >>> df = pd.DataFrame({"A": pd.Series([True, False, True, False], dtype="bool[pyarrow]"), "B": pd.Series([1,2,3,4], dtype="Int64")})

In [5]: df
Out[5]: 
       A  B
0   True  1
1  False  2
2   True  3
3  False  4

In [6]: df.groupby("A").count().dtypes
Out[6]: 
B    int64
dtype: object

@mroeschke mroeschke added the NA - MaskedArrays Related to pd.NA and nullable extension arrays label Jun 29, 2023
@Charlie-XIAO
Copy link
Contributor

Seems that count_level_2d is explicitly using dtype="i8", and similarly size is using dtype=int64 that lead to the issue. What is the recommended way to convert to the correct dtype backend based on the original data type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Bug Dtype Conversions Unexpected or buggy dtype conversions Groupby NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants