BUG: groupby.count maintains masked and arrow dtypes #54129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Groupby
NA - MaskedArrays
|
Looks like tests are passing here so merging. Happy to follow up if needed |
rhshadrach
reviewed
Jul 24, 2023
| if op_name != "count": | ||
| # the result is not yet consistently using Int64/Float64 dtype, | ||
| # so for now just checking the values by casting to float | ||
| result = result.astype("float64") |
There was a problem hiding this comment.
Out of scope here, but I think this might pass now without the cast? Should probably be xfailed if not. I plan to look into this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.