Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: utcnow, utcfromtimestamp #56680

Merged
merged 4 commits into from
Jan 8, 2024
Merged

DEPR: utcnow, utcfromtimestamp #56680

merged 4 commits into from
Jan 8, 2024

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Dec 29, 2023 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

The stdlib has deprecated these, let's do it too!

@MarcoGorelli
Copy link
Member

ok with the idea - looks like ci is red?

@lithomas1 lithomas1 added the Deprecate Functionality to remove in pandas label Jan 4, 2024
MarcoGorelli
MarcoGorelli approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mroeschke mroeschke added this to the 2.3 milestone Jan 8, 2024
@mroeschke mroeschke merged commit 764b1ef into pandas-dev:main Jan 8, 2024
54 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@github-actions github-actions bot mentioned this pull request Jan 8, 2024
Open
17 tasks
@jbrockmendel jbrockmendel deleted the depr-utcnow branch January 8, 2024 21:42
@lithomas1 lithomas1 modified the milestones: 2.3, 3.0 Jan 11, 2024
@MarcoGorelli MarcoGorelli mentioned this pull request Jan 18, 2024
Open
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@jbrockmendel @pmhatre1
DEPR: utcnow, utcfromtimestamp (pandas-dev#56680)
fe45a91 
* DEPR: utcnow, utcfromtimestamp

* GH ref

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbrockmendel @MarcoGorelli @mroeschke @lithomas1