-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: List of deprecations to be removed in 3.0 #50578
Comments
#50052 should not be om this list, it is part of the pandas 1.x -> 2.0 cleanup process. |
Likewise #49560. EDIT: ive removed both of them from the list. |
Could you add this one to the list please?: DEPR: Series.first() and DataFrame.first() |
I've added it, thanks @DeaMariaLeon. More generally, I can see several deprecatons in the pulse that have not been added, e.g. #52986 & #52981. To my knowledge all deprecations should be added to the list, or has that changed? |
@pandas-dev/pandas-core, looks like we need to be more mindful of adding deprecations to this list. Or is there an alternative method of knowing which deprecations have been done? |
There was supposed to be a job that @phofl created that would update the OP https://github.com/pandas-dev/pandas/blob/main/.github/workflows/deprecation-tracking-bot.yml Has it not been working recently? |
I don't think it ever worked except on his repo for some reason. Here's the log of a recent run |
Ok, here's my best guess to what's going wrong. So Github typically restricts the types of perms a workflow can get if it comes from a fork (you get downgraded to read access). When Patrick tested his code on his fork, he opened a PR from a branch within the fork, so the PR was able to get write perms since it came from the same repo. However, when we PR to the main pandas repo, we do it from our forks, not from branches in the main repo, triggering the permissions downgrade. I think the solution is to run the workflow with a Probably need https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#list-pull-requests-associated-with-a-commit to map the commit back to the original PR. I'll try to have something up soonish. |
Thx for fixing the bot! |
@natmokval can you check off the boxes above that you have already handled. i think you've done a bunch of them |
thanks @jbrockmendel. I tried to check the boxes off, but it didn't work. Maybe I don't have permissions to do it. |
@natmokval - that's surprising, I would think triage permissions would allow you to edit any comment. Are you able to edit this comment? In the meantime, you could list the PRs to be checked off in a comment here and someone else can update the OP. |
darn, thanks for taking a look. |
no, I can't edit this comment. I am allowed to edit only my comments.
thanks, @rhshadrach. Here the list of PR’s to be checked off:
I noticed a couple of missing PRs, which are need to be checked off too:
the follow PR is also not on the list: but I am not finished with the removal yet. |
Thanks @natmokval - I've checked off all PRs.
The 2nd I found in the OP list, however I did not find the first. Should it be added? |
thanks @rhshadrach.
yes, I think we should add the first PR in the OP list in 2.0 section. I enforced this deprecation in #58029. |
Thanks @natmokval - done. |
@rhshadrach there are a few more that need to be checked off (correct me if I'm wrong):
enforced by #57425 by #58314 and #58060 respectively by #57971 also by #57971 by #58053 by #57425 I can't find where, but I think this has been enforced by #57999 by #58125 by #58059 Should be removed from the list, was reverted in #56481 by #57966 |
Here is the list of PR’s enforced by CLN: enforce deprecation of frequencies deprecated for offsets #57986:
@rhshadrach, could you please check them off? should not be on this list, because it is not a deprecation. This PR is s a correction |
Thanks @DeaMariaLeon - done. |
xref #30228
When opening a PR that introduces a deprecation (starts warning), please add it to this list, so we know what needs to be fully deprecated when releasing pandas 3.0.
2.0
2.1
obj
from GroupByget_group
#57136)keepdims
check insideblk_func
inDataFrame._reduce
)2.2
The text was updated successfully, but these errors were encountered: