Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential regression with PR "PERF: Eliminate circular references in accessor attributes (#58733)" #58790

Closed
DeaMariaLeon opened this issue May 19, 2024 · 1 comment
Closed

Potential regression with PR "PERF: Eliminate circular references in accessor attributes (#58733)" #58790

DeaMariaLeon opened this issue May 19, 2024 · 1 comment

Comments

@DeaMariaLeon
Copy link
Member

PR #58733
@mroeschke

"timedelta.DatetimeAccessor.time_dt_accessor (Python)": "http://57.128.112.95:5000/compare/benchmarks/066467babb5f75c48000d22a902d6b27...066467cc0d4a7983800091d8b6c588f8"
}

Screenshot 2024-05-19 at 15 49 00
@mroeschke
Copy link
Member

Thanks for the ping but this regression is a known trade off given the potential memory savings so closing #58733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroeschke @DeaMariaLeon