Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataReader should cache queries. #8713

Closed
femtotrader opened this issue Nov 2, 2014 · 8 comments
Closed

DataReader should cache queries. #8713

femtotrader opened this issue Nov 2, 2014 · 8 comments

Comments

@femtotrader
Copy link

Hello,

each request using pandas.io.data.DataReader ends by a server request.
That's not reasonable.
Maybe a cache for DataReader should be considered.

Kind regards

@jreback
Copy link
Contributor

jreback commented Nov 2, 2014

see here: #6456

I think this is out-of-scope for pandas directly. That said if someone wanted to implemented this (via the requests library, I think we would accept it).

@jorisvandenbossche
@TomAugspurger
@cpcloud

?

@TomAugspurger
Copy link
Contributor

Agreed with it being out of scope.

@MichaelWS
Copy link
Contributor

requests_cache is relatively transparent, but I am not sure on how unreasonable it is.

If I have a function that gets historical data from yahoo, I feel like the caching should be done by choice by the user.

@femtotrader
Copy link
Author

Hello,

I've been working on this issue see
https://github.com/femtotrader/pandas_datareaders
but I need some help with some DataReaders.

@jreback
Copy link
Contributor

jreback commented Jan 21, 2015

@kay1793 let try to have constructive comments
thank you for all you contributions

@kay1793
Copy link

kay1793 commented Jan 22, 2015

@jreback, I'm trying but you censoring criticism and erasing comments isn't helping.
Would you please explain what you mean by it is out of scope but will accept PR? I still find this confusing.

@MichaelWS
Copy link
Contributor

I will step in. This is a discussion about separating pandas datareader functionality from pandas.

Pandas is intended to be a middleware data layer.

@davidastephens
Copy link
Contributor

This was added to pandas-datareader v0.2.1, so this issue can be closed.

@jreback jreback closed this as completed Nov 28, 2015
@jorisvandenbossche jorisvandenbossche modified the milestones: No action, Next Major Release Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants