Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: timeseries accessors naming convention #9606

Closed
jreback opened this issue Mar 6, 2015 · 2 comments · Fixed by #37390
Closed

API: timeseries accessors naming convention #9606

jreback opened this issue Mar 6, 2015 · 2 comments · Fixed by #37390
Assignees
@abhishekmangla
Labels
API - Consistency Internal Consistency of API/Behavior API Design Datetime Datetime data dtype good first issue
Milestone
1.2

Comments

@jreback
Copy link
Contributor

jreback commented Mar 6, 2015

we have a slightly odd naming convention for several index (and .dt) accessors

dayofweek
dayofyear

(and adding daysinmonth in #9605)

so these should prob be day_of_week

we should be able to maintain compat on these and just add the new ones.
@jreback jreback added Datetime Datetime data dtype API Design labels Mar 6, 2015
@jreback jreback added this to the 0.16.1 milestone Mar 6, 2015
@jreback jreback mentioned this issue Mar 6, 2015
Merged
@jreback jreback modified the milestones: 0.17.0, 0.16.1 Apr 28, 2015
@jreback jreback modified the milestones: Next Major Release, 0.17.0 Aug 15, 2015
@jreback jreback mentioned this issue Oct 30, 2015
Merged
@emilydolson emilydolson mentioned this issue Oct 31, 2015
Closed
@oleksii-polovyi oleksii-polovyi mentioned this issue Mar 29, 2019
Closed
4 tasks
@Violet-XiaoWeiHuang
Copy link

Hello @jreback ,
I'm a new comer to Pandas, I notice there're other timeseries accessors like 'weekofyear'. Do you want me to work on it?
Thank you.

@Violet-XiaoWeiHuang Violet-XiaoWeiHuang mentioned this issue Apr 15, 2019
Closed
4 tasks
@jbrockmendel jbrockmendel added the API - Consistency Internal Consistency of API/Behavior label Sep 20, 2020
@abhishekmangla
Copy link
Contributor

take

abhishekmangla added a commit to abhishekmangla/pandas that referenced this issue Oct 24, 2020
@abhishekmangla
CLN: Deprecate dayofweek/hello day_of_week (pandas-dev#9606)
d1524a4 
Rename dayofweek properties in Period, Datetime, and PeriodArray classes.
Add day_of_week property to respective tests for each class.
@abhishekmangla abhishekmangla mentioned this issue Oct 24, 2020
Merged
5 tasks
abhishekmangla added a commit to abhishekmangla/pandas that referenced this issue Oct 25, 2020
@abhishekmangla
ENH: Support day_of_year over dayofyear (pandas-dev#9606)
bb01751 
Similar to changes for day_of_week, create aliases for day_of_year and add to respective test files to ensure back-compat.
Also fix whatsnew rst file
abhishekmangla added a commit to abhishekmangla/pandas that referenced this issue Oct 26, 2020
@abhishekmangla
CLN: Deprecate dayofweek/hello day_of_week (pandas-dev#9606)
b0cba8e 
Rename dayofweek properties in Period, Datetime, and PeriodArray classes.
Add day_of_week property to respective tests for each class.
abhishekmangla added a commit to abhishekmangla/pandas that referenced this issue Oct 26, 2020
@abhishekmangla
ENH: Support day_of_year over dayofyear (pandas-dev#9606)
a4b88df 
Similar to changes for day_of_week, create aliases for day_of_year and add to respective test files to ensure back-compat.
Also fix whatsnew rst file
@jreback jreback modified the milestones: Contributions Welcome, 1.2 Oct 26, 2020
jreback pushed a commit that referenced this issue Oct 29, 2020
@abhishekmangla
CLN: Deprecate dayofweek/hello day_of_week (#9606) (#37390)
10e5ad7
kesmit13 pushed a commit to kesmit13/pandas that referenced this issue Nov 2, 2020
@abhishekmangla
CLN: Deprecate dayofweek/hello day_of_week (pandas-dev#9606) (pandas-…
de44821 
…dev#37390)
ukarroum pushed a commit to ukarroum/pandas that referenced this issue Nov 2, 2020
@abhishekmangla @ukarroum
CLN: Deprecate dayofweek/hello day_of_week (pandas-dev#9606) (pandas-…
8c1eded 
…dev#37390)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishekmangla abhishekmangla

Labels
API - Consistency Internal Consistency of API/Behavior API Design Datetime Datetime data dtype good first issue
Projects
None yet
Milestone
1.2
5 participants
@jreback @TomAugspurger @jbrockmendel @abhishekmangla @Violet-XiaoWeiHuang