DEPR: Deprecate str.split return_type #10085
Conversation
| @@ -742,10 +735,7 @@ def str_split(arr, pat=None, n=None, return_type='series'): | |||
| n = 0 | |||
| regex = re.compile(pat) | |||
| f = lambda x: regex.split(x, maxsplit=n) | |||
| if return_type == 'frame': | |||
| res = DataFrame((Series(x) for x in _na_map(f, arr)), index=arr.index) | |||
There was a problem hiding this comment.
isn't this what expand=True does (and btw, can easily fix #10081) at the same time, just take out the use of Series here.
There was a problem hiding this comment.
yes, the logic is replaced to _wrap_results_expand.
I think #10081 should be considered separately, because we can't simply use workaround for all the cases.
s = pd.Series([1.1, '2.2'])
# current behavior
s.str.split('.', expand=True)
# 0 1
# 0 NaN NaN
# 1 2 2
# workaround
pd.read_table(StringIO(s.to_csv(None, index=None)), sep='.')
# 1 1.1
# 0 2 2
# numpy
pd.DataFrame(list(np.core.defchararray.split(s.values.astype(str), '.')))
# 0 1
# 0 1 1
# 1 2 2
| @@ -221,6 +221,28 @@ enhancements are performed to make string operation easier. | |||
| idx.str.startswith('a') | |||
| s[s.index.str.startswith('a')] | |||
|
|
|||
|
|
|||
| - ``split`` now takes ``expand`` keyword to specify returning dimensionality. ``return_type`` is deprecated. (:issue:`9847`) | |||
There was a problem hiding this comment.
"returning dimensionality" should be "expanding dimensionality"
There was a problem hiding this comment.
how about "specify whether to expand dimensionality"?
There was a problem hiding this comment.
Sounds good!
On May 8, 2015, at 8:59 PM, Sinhrks notifications@github.com wrote:
In doc/source/whatsnew/v0.16.1.txt:
@@ -221,6 +221,28 @@ enhancements are performed to make string operation easier.
idx.str.startswith('a')
s[s.index.str.startswith('a')]
+-
splitnow takesexpandkeyword to specify returning dimensionality.return_typeis deprecated. (:issue:9847)
how about "specify whether to expand dimensionality"?—
Reply to this email directly or view it on GitHub.
|
Looks good! Another thing I encountered while reviewing: there is no good explanation of the |
|
@jorisvandenbossche Explanation of I also found current arg names are different from standard |
Closes #9847, Closes #9870. Default value is
expand=Falseto be compat withreturn_type='series'. May better to change the default to True in future (and show warning about it)?CC @jreback @jorisvandenbossche @sreejata