Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: Fix to_dict() problem when using datetime DataFrame #11247 #11327
Conversation
|
see guidelines here: http://pandas.pydata.org/pandas-docs/stable/contributing.html dont' turn on PEP changes for your editor. |
|
I think I forgot to fetch to update my local master before my first commit to this PR. Somehow I messed up is it true? |
|
add tests! (ideally for each one of the orients if we dont' have already). |
jreback
added Bug Output-Formatting Dtypes
labels
Oct 14, 2015
|
which test case shall I add in? I am new to this :)
|
|
@jreback I have added tests:) |
jreback
commented on the diff
Oct 15, 2015
| @@ -4728,6 +4728,36 @@ def test_to_dict(self): | ||
| for k2, v2 in compat.iteritems(v): | ||
| self.assertEqual(v2, recons_data[k2][k]) | ||
| + def test_to_dict_timestamp(self): | ||
| + # GH11247 | ||
| + tsmp = Timestamp('20130101') | ||
| + test_data = DataFrame({'A': [tsmp, tsmp], 'B': [tsmp, tsmp]}) |
jreback
Contributor
|
|
pls add a whatsnew note for 0.17.1 in bug fixes |
jreback
added this to the
0.17.1
milestone
Oct 15, 2015
|
Just asking what I should do if I merge updates locally with my branch and need to merge the 2 commits into one.. — On Fri, Oct 16, 2015 at 6:25 AM, Jeff Reback notifications@github.com
|
|
merged via 89b4e5b thanks! |
ethanluoyc commentedOct 14, 2015
closes #11247
This is my first time contributing through PR so forgive me if I make any silly mistake.
The issue can be referred to in GH11247
I followed @jreback 's suggestion to box things up in
to_dict()but I am not sure if this is what he means because I do not know exactly when_maybe_datetime()should be used. Initially I tried to tweakinternals.pybut it fails.Let me know how I can improve from here. Hope I can really learn from my first PR.