Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: .loc assignment of datetime with tz is coercing to naive #11365 #11377

Closed
wants to merge 1 commit into from
Closed

BUG: .loc assignment of datetime with tz is coercing to naive #11365 #11377

wants to merge 1 commit into from

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Oct 19, 2015

closes #11365

@taeold taeold closed this Oct 19, 2015
@taeold
Copy link
Contributor Author

taeold commented Oct 19, 2015

sorry - i realize the fix is incomplete. will close and submit a new pull request soon.

jreback
jreback reviewed Oct 19, 2015
View reviewed changes
pandas/core/common.py
v = np.array(val,copy=False)
if is_datetimelike(v):
if is_datetimetz(val):
return pd.DatetimeIndex(v, dtype=val.dtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be v? (and not val)

@jreback
Copy link
Contributor

jreback commented Oct 19, 2015

you don't need to close
just push more commits in this one

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Timezones Timezone data dtype labels Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Timezones Timezone data dtype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: .loc assignment of datetime with tz is coercing to naive
2 participants
@taeold @jreback