Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: add CFLAGS -fgnu89-inline on FreeBSD 10+ #11398

Merged
merged 1 commit into from Nov 10, 2015

Conversation

iblislin
Copy link
Contributor

closes #10510

@jreback jreback added the Build Library building on various platforms label Oct 21, 2015
@jreback
Copy link
Contributor

jreback commented Oct 21, 2015

can you add a whatsnew note as well.

pls confirm that this works for you as well. (e.g. download in a clean env and build). pls try on 2.7/3.5

@jreback jreback added this to the 0.17.1 milestone Oct 21, 2015
@iblislin iblislin changed the title [#10510] add CFLAGS -fgnu89-inline on FreeBSD 10+ BLD: add CFLAGS -fgnu89-inline on FreeBSD 10+ Oct 21, 2015
@iblislin iblislin force-pushed the gnu-inline branch 2 times, most recently from 1484ff8 to 2a36b5a Compare October 21, 2015 16:21
@iblislin
Copy link
Contributor Author

Hi @jreback !
The whatsnew note added.

I ran the testing for 2.7 and 3.5 .... and i got some failures

  • python3.5: 1 error; 5 failures
  • python 2.7: no error; 5 failures

More detail is on gist

I also tried this: In py35 venv, switch to master branch, set CC to gnu48 , build pandas, and run the testing.
Unfortunately, it failed again. The failure report is almost same as previous one.

@kawochen
Copy link
Contributor

these are the same failures that another user has been getting see #11388

@jreback
Copy link
Contributor

jreback commented Nov 10, 2015

can you give a squash. ping when green. (and confirm that this works on FreeBSD!)

@iblislin
Copy link
Contributor Author

@jreback The commits squashed. Most of features works fine on FreeBSD. 😄

There is few test cases falied on FreeBSD, but i think it's another issues.

jreback added a commit that referenced this pull request Nov 10, 2015
BLD: add CFLAGS `-fgnu89-inline` on FreeBSD 10+
@jreback jreback merged commit 49a15b1 into pandas-dev:master Nov 10, 2015
@jreback
Copy link
Contributor

jreback commented Nov 10, 2015

@iblis17 thanks.

When we release 0.17.1 (prob 2 weeks). pls comment if any remaining issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation problem on FreeBSD 10.0 with Python 3.4.3
3 participants