Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll apply nonfloat dtypes #11620

Closed
wants to merge 3 commits into from
Closed

Roll apply nonfloat dtypes #11620

wants to merge 3 commits into from

Commits on Nov 16, 2015

  1. ENH: GH4964 Separated array_to_roll in roll_generic 

    In fixing GH4964, added an array_to_roll argument to roll_generic().
This will be used by rolling_apply() to work with non-float dtypes.
array_to_roll defaults to None in which case, this function rolls over
input array as it did previously.
    Jasmine Sandhu committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    af060ba View commit details
    Browse the repository at this point in the history

  2. ENH: GH4964 Add coercion kwarg to rolling_apply 

    Added coercion bool in rolling_apply and _process_data_structure()
It defaults to True in which case the _process_data_structure() converts
arg to float and things work as they did before this change (backwards
compatible). If user wishes to use rolling_apply() with string array,
then set coercion=False.

Default of coercion=True prioritizes performance.
    Jasmine Sandhu committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    da418ef View commit details
    Browse the repository at this point in the history

  3. ENH: GH4964 Add rolling_apply on strings as test

    Jasmine Sandhu committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    ba73145 View commit details
    Browse the repository at this point in the history