BUG #11638 return correct dtype for int and float #11644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests! |
varunkumar-dev
force-pushed
the
fix_dtype_change_bug
branch
from
dfb26e9
to
cc79bff
Compare
|
Added test case . |
|
@varun-kr looks good. can you add a release not to whatsnew/0.17.0 in bug fixes. |
|
It should be 0.17.1. Right ? |
|
yep |
Added test case TestInferDtype
varunkumar-dev
force-pushed
the
fix_dtype_change_bug
branch
from
cc79bff
to
c61020e
Compare
|
ping when green. |
|
Done. |
|
merged via 24cdf45 I expanded the tests a bit, thanks for the push! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11638
Please review.