BUG: Parsing offset strings with non-zero minutes was incorrect #11774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -722,6 +722,8 @@ def test_parsing_timezone_offsets(self): | |||
| '2013-01-01T08:00:00.000000000+0800', | |||
| '2012-12-31T16:00:00.000000000-0800', | |||
| '12-31-2012 23:00:00-01:00', | |||
| '2013-01-01 05:45+05:45', #GH11708 | |||
| '2013-01-01 05:30+05:30', #GH11708 | |||
There was a problem hiding this comment.
this is fine, but we also need a test asserting that these are the correct times when localized (e.g. like the example in the original bug report)
|
this does not close #11481 , correct? |
|
Correct, that's a lot uglier. |
|
Tests added for to_datetime and Timestamp constructor and are green. |
jreback
added a commit
that referenced
this pull request
Dec 7, 2015
BUG: Parsing offset strings with non-zero minutes was incorrect
|
thank you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11708
Minutes needed to be added to the hour offset rather than subtracted.