Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: drop suppport for python 2.6, #7718 #11988

Merged
merged 1 commit into from
Jan 8, 2016
Merged

COMPAT: drop suppport for python 2.6, #7718 #11988

merged 1 commit into from
Jan 8, 2016

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 7, 2016

closes #8760
closes #7718

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Jan 7, 2016
@jreback jreback added this to the 0.18.0 milestone Jan 7, 2016
@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

any complaints, comments, objections?

@kawochen
Copy link
Contributor

kawochen commented Jan 7, 2016

😄 compat will get 400 lines shorter

@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

oh do I need to things out?

@kawochen
Copy link
Contributor

kawochen commented Jan 7, 2016

OrderedDict and Counter

@TomAugspurger
Copy link
Contributor

This came up on the scikit-learn mailing list last week. I don't think they've come to a decision yet.

If we are approaching a 1.0 this year we should think about what we want to support indefinitely. I think that's an argument for dropping 2.6.

Also, dict comprehensions 🙌

@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

yes, I need to make an issue for what we want to add (also can use things like .assertGreater and such in testing).

@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

@kawochen turned out to be 478 lines! (unless I took out too much)

@jreback jreback mentioned this pull request Jan 7, 2016
Closed
kawochen
kawochen reviewed Jan 7, 2016
View reviewed changes
pandas/compat/__init__.py
from collections import OrderedDict, Counter
from collections import OrderedDict, Counter
from operator import itemgetter
from heapq import nlargest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two lines can be taken out too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

puzzled while ChainMap is not in 2.7. It says it has it, but not when I look. oh well.

@kawochen
Copy link
Contributor

kawochen commented Jan 7, 2016 

In [115]: from ConfigParser import _Chainmap as ChainMap

@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

wow, that's an odd place to have it!

@kawochen
Copy link
Contributor

kawochen commented Jan 7, 2016

If you search for 26, you will find a few more places that can be tweaked (e.g. windows build script)

@jreback
Copy link
Contributor Author

jreback commented Jan 7, 2016

@kawochen thanks.

updated

jreback added a commit that referenced this pull request Jan 8, 2016
@jreback
Merge pull request #11988 from jreback/py2.6
64b6fee 
COMPAT: drop suppport for python 2.6, #7718
@jreback jreback merged commit 64b6fee into pandas-dev:master Jan 8, 2016
@jreback
Copy link
Contributor Author

jreback commented Jan 8, 2016

bombs away

@jtkiley jtkiley mentioned this pull request Jan 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

TST: require unittest2 for testing on Python 2.6? COMPAT: drop support for python 2.6
3 participants
@jreback @kawochen @TomAugspurger