Fix #12037 Error when Resampling using pd.tseries.offsets.Nano as period #12270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ts = pd.Series(np.random.randn(len(indx)), index=indx) | ||
| r = ts.resample(pd.tseries.offsets.Nano(100)) | ||
| r.agg('mean') | ||
|
|
There was a problem hiding this comment.
you need to have an expected as a comparison
| @@ -854,9 +854,11 @@ def _get_time_bins(self, ax): | |||
| closed=self.closed, | |||
| base=self.base) | |||
| tz = ax.tz | |||
| # do not call replace() because that will swallow the nanosecond part | |||
There was a problem hiding this comment.
maybe a better comment as once we delete .replace its not clear what you are doing.
|
looks reasonable, some comments. pls add a whatsnew entry. |
cldy
pushed a commit
to cldy/pandas
that referenced
this pull request
Feb 11, 2016
…ano as period Closes pandas-dev#12037 Author: Bran Yang <snowolfy@163.com> Closes pandas-dev#12270 from BranYang/nanosec and squashes the following commits: bff0c85 [Bran Yang] Add to whatsnew and some comments fd0b307 [Bran Yang] Fix pandas-dev#12037 Error when Resampling using pd.tseries.offsets.Nano as period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12037