CLN: consolidate Series.quantile and DataFrame.quantile #12469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collabed with @sergeibernstein on this, commenting here for alerts on any issues. |
| values = arr.astype(float) | ||
| values = values[notnull(values)] | ||
| if len(values) == 0: | ||
| return NA |
sergeibernstein
force-pushed
the
cons
branch
from
9416b5a
to
e027df0
Compare
| "are not supported in numpy < 1.9") | ||
|
|
||
| def f(arr, per, interpolation): | ||
| boxer = com.i8_boxer(arr) \ |
There was a problem hiding this comment.
you can combine these in 1
its either a needs_i8_conversion (where you need a boxer), or its not (and we upcast to float)
|
can you rebase on master, and some PEP errors. thxs. |
5 tasks
jreback
pushed a commit
to jreback/pandas
that referenced
this pull request
Apr 3, 2016
CLN: clean up quantile & move to BlockManager closes pandas-dev#12741 closes pandas-dev#12772 closes pandas-dev#12469 closes pandas-dev#12752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff