BUG: GH12558 where nulls contributed to normalized value_counts #12566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Bug
Missing-data
| @@ -43,3 +43,5 @@ Performance Improvements | |||
|
|
|||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - Bug in `Series.value_counts` when `normalize=True` and `dropna=True` where nulls still contributed to the normalized count (:issue:`12558`) | |||
kawochen
force-pushed
the
BUG-FIX-12558
branch
2 times, most recently
from
934531f
to
b2d5b25
Compare
|
@nickeubank tests passed. Does this look OK? |
| d = np.diff(np.r_[idx, len(ids)]) | ||
| if dropna: | ||
| m = ids[lab == -1] | ||
| if compat.numpy_compat._np_version_under1p8: |
There was a problem hiding this comment.
from pandas import _np_version_under1p8 (do the import at the top)
|
done |
|
Looks great! |
|
thanks @kawochen @nickeubank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff