BUG: #12624 where Panel.fillna() ignores inplace=True #12630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #12624 Author: Pedro M Duarte <pmd323@gmail.com>
jreback
added
Bug
Missing-data
| @@ -3122,7 +3122,8 @@ def fillna(self, value=None, method=None, axis=None, inplace=False, | |||
| elif self.ndim == 3: | |||
|
|
|||
| # fill in 2d chunks | |||
| result = dict([(col, s.fillna(method=method, value=value)) | |||
| result = dict([(col, s.fillna(method=method, value=value, | |||
There was a problem hiding this comment.
this doesn't work as if inplace=True returns None.
jreback
changed the title
|
xref #12633 |
|
duped in #12633 thanks! |
|
Thanks for the feedback, Jeff! I wanted to get home to fix it but seems like it has been taken care of. Will look for another easy one I can try to help with. |
|
@PedroMDuarte np. this actually happens pretty rarely when 2 people are working on the same issue. In any event lots of issues to try for! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffFixes #12624
Author: Pedro M Duarte pmd323@gmail.com