BUG 12800 fixed inconsistent behavior of last_valid_index and first_valid_index #12834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
added
Bug
Indexing
| @@ -336,3 +336,8 @@ def test_first_last_valid(self): | |||
|
|
|||
| index = frame.last_valid_index() | |||
| self.assertEqual(index, frame.index[-6]) | |||
|
|
|||
| def test_empty_first_last(self): | |||
| empty_frame = DataFrame() | |||
There was a problem hiding this comment.
add the issue number as a comment (and below)
|
pls add a whatsnew note (bug fixes) |
|
I went ahead and added the whats new note and the comments in the bug. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff