BUG: Datetime64Formatter not respecting formatter
#13567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haleemur
changed the title
formatter
| self.assertEqual(result, ['2016-01', '2016-02', '2016-03']) | ||
|
|
||
| def test_format_dataframe_column(self): | ||
| months = [datetime(2016,1,1), datetime(2016,2,2), datetime(2016,3,3)] |
There was a problem hiding this comment.
this last test goes with all of the test_to_string* tests.
| @@ -4161,6 +4161,21 @@ def test_dates_display(self): | |||
| self.assertEqual(result[1].strip(), "NaT") | |||
| self.assertEqual(result[4].strip(), "2013-01-01 09:00:00.000000004") | |||
|
|
|||
| def test_datetime64formatter(self): | |||
| x = Series([datetime(2016,1,1), datetime(2016,2,2), datetime(2016,3,3)]) | |||
There was a problem hiding this comment.
add a test where to_html are tested as well
jorisvandenbossche
added
the
IO HTML
Current coverage is 84.34%@@ master #13567 diff @@
==========================================
Files 138 138
Lines 51155 51135 -20
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43130 43132 +2
+ Misses 8025 8003 -22
Partials 0 0
|
|
lgtm. |
| @@ -528,3 +528,5 @@ Bug Fixes | |||
|
|
|||
| - Bug in ``Categorical.remove_unused_categories()`` changes ``.codes`` dtype to platform int (:issue:`13261`) | |||
| - Bug in ``groupby`` with ``as_index=False`` returns all NaN's when grouping on multiple columns including a categorical one (:issue:`13204`) | |||
|
|
|||
There was a problem hiding this comment.
note the reason we leave space in the bug fix section is to avoid conflicts (IOW put up higher in a blank space). @jorisvandenbossche you prob want to move on merge.
There was a problem hiding this comment.
thanks for the tip, added blank lines before my bugfix entry. hope that helps with the merge.
…output for df.to_string, df.to_html methods added tests for time of day formatting and df.to_html added test for formatters kw for df.to_latex add whatsnew entry move whatsnew entry higher up
|
@haleemur Merged, thanks a lot! (I moved the whatsnew note to 0.19.0, as master is now targeted for that) |
nateGeorge
pushed a commit
to nateGeorge/pandas
that referenced
this pull request
Aug 15, 2016
- [x] closes pandas-dev#10690 - [x] tests added / passed - [x] passes ``git diff upstream/master | flake8 --diff`` - [x] whatsnew entry the Datetime64Formatter class did not accept a `formatter` argument, so custom formatters passed in through `df.to_string` or `df.to_html` were silently ignored. Author: Haleemur Ali <haleemur@gmail.com> This patch had conflicts when merged, resolved by Committer: Joris Van den Bossche <jorisvandenbossche@gmail.com> Closes pandas-dev#13567 from haleemur/fix/dt64_outputformat and squashes the following commits: 8d84283 [Haleemur Ali] fix bug in Datetime64Formatter, which affected custom date formatted output for df.to_string, df.to_html methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffthe Datetime64Formatter class did not accept a
formatterargument, so custom formatters passed in throughdf.to_stringordf.to_htmlwere silently ignored.