Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: Improve Period hashing #13705

Closed
wants to merge 1 commit into from
Closed

PERF: Improve Period hashing #13705

wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jul 19, 2016 

# asv
-   33.75ms     3.22ms      0.10  period.period_algorithm.time_period_series_drop_duplicates

@sinhrks sinhrks added Performance Memory or execution speed performance Period Period data type labels Jul 19, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 19, 2016
jreback
jreback reviewed Jul 19, 2016
View reviewed changes
pandas/tseries/tests/test_base.py
@@ -2164,6 +2226,28 @@ def test_drop_duplicates_metadata(self):
self.assert_index_equal(idx, result)
self.assertEqual(idx.freq, result.freq)

def test_drop_duplicates(self):
# to check Index/Series compat
base = pd.period_range('2011-01-01', '2011-01-31', freq='D',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this duplicated code with above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the code directly above intends to check metadata. others look similar are for datetime/timedelta. though we have index/series separated tests, I thinks it's good chance to check index/series compat.

@jreback
Copy link
Contributor

jreback commented Jul 19, 2016

i think this needs a rebase

@codecov-io
Copy link

Current coverage is 84.54%

Merging #13705 into master will not change coverage

@@             master     #13705   diff @@
==========================================
  Files           141        141          
  Lines         51161      51161          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43252      43252          
  Misses         7909       7909          
  Partials          0          0

Powered by Codecov. Last updated by 4c9ae94...e1fb7f4

@jreback jreback changed the title PERF: Improve Period hasing PERF: Improve Period hashing Jul 19, 2016
@jreback
Copy link
Contributor

jreback commented Jul 20, 2016

thanks!

@jreback jreback closed this in 016b352 Jul 20, 2016
@sinhrks sinhrks deleted the period_hash branch July 20, 2016 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Performance Memory or execution speed performance Period Period data type
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

ENH: Faster hashing of Period objects
3 participants
@sinhrks @jreback @codecov-io