BUG: No affect both index and column(GH 13522) #14005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.29% (diff: 100%)@@ master #14005 diff @@
==========================================
Files 139 139
Lines 50245 50247 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42857 42859 +2
Misses 7388 7388
Partials 0 0
|
jreback
added
Bug
Indexing
|
can you run an asv and see if anything changed signficantly. lgtm otherwise. |
| @@ -861,6 +861,7 @@ Bug Fixes | |||
| - Bug in ``io.json.json_normalize()``, where non-ascii keys raised an exception (:issue:`13213`) | |||
| - Bug when passing a not-default-indexed ``Series`` as ``xerr`` or ``yerr`` in ``.plot()`` (:issue:`11858`) | |||
| - Bug in area plot draws legend incorrectly if subplot is enabled or legend is moved after plot (matplotlib 1.5.0 is required to draw area plot legend properly) (issue:`9161`, :issue:`13544`) | |||
| - Bug in ``DataFrame``, assigning a string index as a column once can make further assignments affect both index and column (:issue:`13522`) | |||
There was a problem hiding this comment.
maybe something like: Bug in DataFrame assignment with an object-dtyped Index where the resultant column is mutable to the original object.
conquistador1492
force-pushed
the
issue_13522
branch
from
285bb84
to
6dfd2bc
Compare
|
@jreback all benchmarks not significantly changed beside groupby.groupby_frame_singlekey_integer.time_sum. It ranges from 1 to 1.2 |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff