BUG: GH11847 Unstack with mixed dtypes coerces everything to object #14053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unstacked1 = df.unstack(['index']) | ||
| unstacked2 = df.unstack('index') | ||
| assert_frame_equal(unstacked1, unstacked2) | ||
| assert_numpy_array_equal(df.dtypes.values, unstacked1.dtypes.values) |
There was a problem hiding this comment.
no need to compare vs numpy
frame_equal does this
kordek
force-pushed
the
#11847
branch
2 times, most recently
from
f2f08c3
to
18ab88c
Compare
Current coverage is 85.24% (diff: 100%)@@ master #14053 diff @@
==========================================
Files 143 143
Lines 50849 50851 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43343 43346 +3
+ Misses 7506 7505 -1
Partials 0 0
|
| @@ -1079,3 +1079,4 @@ Bug Fixes | |||
| - Bug in ``Index`` raises ``KeyError`` displaying incorrect column when column is not in the df and columns contains duplicate values (:issue:`13822`) | |||
| - Bug in ``Period`` and ``PeriodIndex`` creating wrong dates when frequency has combined offset aliases (:issue:`13874`) | |||
| - Bug in ``.to_string()`` when called with an integer ``line_width`` and ``index=False`` raises an UnboundLocalError exception because ``idx`` referenced before assignment. | |||
| - Bug in ``unstack()`` causes specific series dtype to be changed to ``object`` (:issue:`11847`) | |||
There was a problem hiding this comment.
not clear to a reader what this means. use more description from the issue
jreback
added
Bug
Reshaping
|
can you rebase / update? |
kordek
force-pushed
the
#11847
branch
2 times, most recently
from
0b7548c
to
47938ad
Compare
|
@jreback is it ok now? |
jreback
reviewed
Nov 16, 2016
| @@ -80,3 +80,5 @@ Performance Improvements | |||
|
|
|||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - Bug in ``unstack()`` If called with list of column(s) as argument, regardless of dtypes all columns get coerced to ``object`` (:issue:`11847`) | |||
There was a problem hiding this comment.
ok to move to 0.19.2
small changes
Bug in unstack() if called with a list of column(s) as an argument, regardless of the dtypes of all columns get coerced to object dtype
kordek
force-pushed
the
#11847
branch
3 times, most recently
from
69dd53e
to
684e34f
Compare
|
@jreback changed as suggested and passing. |
|
@kordek can you add a category dtype the tests as well. lgtm otherwise. |
kordek
force-pushed
the
#11847
branch
2 times, most recently
from
d14873d
to
fe559b3
Compare
Changed the way in which the original data frame is copied (dropped use of .values, since it does not preserve dtypes).
|
@jreback I've changed the tests as requested (if I understood correctly). |
|
thanks @kordek |
jorisvandenbossche
pushed a commit
that referenced
this pull request
Dec 15, 2016
closes #11847 Changed the way in which the original data frame is copied (dropped use of .values, since it does not preserve dtypes). Author: Pawel Kordek <pawel.kordek@gmail.com> Closes #14053 from kordek/#11847 and squashes the following commits: 6a381ce [Pawel Kordek] BUG: GH11847 Unstack with mixed dtypes coerces everything to object (cherry picked from commit d531718)
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
closes pandas-dev#11847 Changed the way in which the original data frame is copied (dropped use of .values, since it does not preserve dtypes). Author: Pawel Kordek <pawel.kordek@gmail.com> Closes pandas-dev#14053 from kordek/pandas-dev#11847 and squashes the following commits: 6a381ce [Pawel Kordek] BUG: GH11847 Unstack with mixed dtypes coerces everything to object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffChanged the way in which the original data frame is copied (dropped use of .values, since it does not preserve dtypes).