Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: add deprecation warning for com.array_equivalent #14567

Merged

Conversation

jorisvandenbossche
Copy link
Member

xref #14555

pandas.core.common.array_equivalent was removed without deprecation warning.
This commits adds it back to the core.common namespace with deprecation warning

We should still decide on the usefulness to add to the public API (in this commit I didn't add any pointer to alternative import location)

@jorisvandenbossche jorisvandenbossche added the Deprecate Functionality to remove in pandas label Nov 2, 2016
@jorisvandenbossche jorisvandenbossche added this to the 0.19.1 milestone Nov 2, 2016
@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 2, 2016
pandas.core.common.array_equivalent was removed without deprecation warning.
This commits adds it back to the core.common namespace with deprecation warning
@codecov-io
Copy link

codecov-io commented Nov 2, 2016

Current coverage is 85.27% (diff: 100%)

Merging #14567 into master will increase coverage by <.01%

@@             master     #14567   diff @@
==========================================
  Files           140        140          
  Lines         50689      50693     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43225      43229     +4   
  Misses         7464       7464          
  Partials          0          0          

Powered by Codecov. Last update 1d95179...d5e5173

@jreback
Copy link
Contributor

jreback commented Nov 2, 2016

lgtm. I would add a note in the release notes as well.

@jorisvandenbossche jorisvandenbossche merged commit 093aa82 into pandas-dev:master Nov 3, 2016
@jorisvandenbossche jorisvandenbossche deleted the array_equivalent branch November 3, 2016 09:37
jorisvandenbossche added a commit that referenced this pull request Nov 3, 2016
…ent (#14567)

pandas.core.common.array_equivalent was removed without deprecation warning.
This commits adds it back to the core.common namespace with deprecation warning
(cherry picked from commit 093aa82)
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Nov 18, 2016
Version 0.19.1

* tag 'v0.19.1': (43 commits)
  RLS: v0.19.1
  DOC: update whatsnew/release notes for 0.19.1 (pandas-dev#14573)
  [Backport pandas-dev#14545] BUG/API: Index.append with mixed object/Categorical indices (pandas-dev#14545)
  DOC: rst fixes
  [Backport pandas-dev#14567] DEPR: add deprecation warning for com.array_equivalent (pandas-dev#14567)
  [Backport pandas-dev#14551] PERF: casting loc to labels dtype before searchsorted (pandas-dev#14551)
  [Backport pandas-dev#14536] BUG: DataFrame.quantile with NaNs (GH14357) (pandas-dev#14536)
  [Backport pandas-dev#14520] BUG: don't close user-provided file handles in C parser (GH14418) (pandas-dev#14520)
  [Backport pandas-dev#14392] BUG: Dataframe constructor when given dict with None value (pandas-dev#14392)
  [Backport pandas-dev#14514] BUG: Don't parse inline quotes in skipped lines (pandas-dev#14514)
  [Bacport pandas-dev#14543] BUG: tseries ceil doc fix (pandas-dev#14543)
  [Backport pandas-dev#14541] DOC: Simplify the gbq integration testing procedure for contributors (pandas-dev#14541)
  [Backport pandas-dev#14527] BUG/ERR: raise correct error when sql driver is not installed (pandas-dev#14527)
  [Backport pandas-dev#14501] BUG: fix DatetimeIndex._maybe_cast_slice_bound for empty index (GH14354) (pandas-dev#14501)
  [Backport pandas-dev#14442] DOC: Expand on reference docs for read_json() (pandas-dev#14442)
  BLD: fix 3.4 build for cython to 0.24.1
  [Backport pandas-dev#14492] BUG: Accept unicode quotechars again in pd.read_csv
  [Backport pandas-dev#14496] BLD: Support Cython 0.25
  [Backport pandas-dev#14498] COMPAT/TST: fix test for range testing of negative integers to neg powers
  [Backport pandas-dev#14476] PERF: performance regression in Series.asof (pandas-dev#14476)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants