Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fix tests catching unorderable errors for python 3.6 #15007

Merged
merged 1 commit into from
Dec 30, 2016

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Dec 29, 2016

See also MacPython/pandas-wheels#8, seems that the order of int and str is switched in some cases (eg https://travis-ci.org/MacPython/pandas-wheels/jobs/187223139). Therefore making the test here more robust.

Related to #14684

See also MacPython/pandas-wheels#8, seems that the order of int and str is switched in some cases. Therefore making the test here more robust.
@jorisvandenbossche jorisvandenbossche added Python 3.6 Testing pandas testing functions or related to the test suite labels Dec 29, 2016
@jorisvandenbossche
Copy link
Member Author

@jreback not sure if this should be changes in _is_unorderable_exception (https://github.com/pandas-dev/pandas/pull/14684/files#diff-779e809bc7bd6d23787580ee9be98729R199) as well. In any case, did not see failing tests related to that in the wheels building for mac.

@jreback
Copy link
Contributor

jreback commented Dec 29, 2016

yeah py 3.6. changed the error message, so maybe should change _is_unorderable_exception as well (to make it less strict), not sure though

@jreback jreback added this to the 0.20.0 milestone Dec 29, 2016
@codecov-io
Copy link

Current coverage is 84.78% (diff: 100%)

Merging #15007 into master will increase coverage by <.01%

@@             master     #15007   diff @@
==========================================
  Files           145        145          
  Lines         51090      51090          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43315      43316     +1   
+ Misses         7775       7774     -1   
  Partials          0          0          

Powered by Codecov. Last update e27b296...da8f8c9

@jreback jreback merged commit 533e7de into pandas-dev:master Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants