Fix gbq integration tests so that unique datasets/table names are used #15009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.78% (diff: 100%)@@ master #15009 diff @@
==========================================
Files 145 145
Lines 51090 51090
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43315 43315
Misses 7775 7775
Partials 0 0
|
jreback
added
IO Google
Testing
|
thanks @parthea ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will resolve an issue where a gbq integration test was failing. The same dataset/table name was used twice in
test_gbq.pywhich could result in a schema conflict if the previous table schema is cached and the new schema has not successfully propagated through Google's backend.See 45910ae
All gbq units tests passed on Travis on my fork : https://travis-ci.org/parthea/pandas/builds/187463043