BUG: Remove locale conversion from Stata file date #15208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not close any issue since this was only identified as part of #13856. Passes all tests (not just slow) when locale is |
bashtage
force-pushed
the
stata-locale-date-fix
branch
from
5a54fc8
to
a23a92f
Compare
jreback
reviewed
Jan 24, 2017
| month_lookup = {i + 1: month for i, month in enumerate(months)} | ||
| ts = (time_stamp.strftime("%d ") + | ||
| month_lookup[time_stamp.month] + | ||
| time_stamp.strftime(" %Y %H:%M")) |
There was a problem hiding this comment.
you could also
with pandas.util.testing.set_locale('en_US.UTF-8'):
....
not sure if this is better though
|
https://travis-ci.org/jreback/pandas/jobs/194872508 oddly this didn't fail on py3. |
Current coverage is 85.99% (diff: 100%)
|
|
can you rebase and push again, just to make sure this passes? ping on green. |
Prevent locale from affecting Stata file date creation, which must be en_US. xref pandas-dev#13856
bashtage
force-pushed
the
stata-locale-date-fix
branch
from
a23a92f
to
a55bfd8
Compare
|
@jreback Green - one test fails in another module that has the same problem due to locales. |
|
thanks for the fix @bashtage |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Prevent locale from affecting Stata file date creation, which must be en_US. xref pandas-dev#13856 Author: Kevin Sheppard <kevin.k.sheppard@gmail.com> Closes pandas-dev#15208 from bashtage/stata-locale-date-fix and squashes the following commits: a55bfd8 [Kevin Sheppard] BUG: Remove locale conversion from Stata file date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent locale from affecting Stata file date creation, which must
be en_US.
xref #13856
git diff upstream/master | flake8 --diff