MAINT: Drop take_last kwarg from method signatures #15710
Conversation
gfyoung
force-pushed
the
create-last-kw-drop
branch
from
d285298
to
f4b329d
Compare
Codecov Report
@@ Coverage Diff @@
## master #15710 +/- ##
==========================================
- Coverage 91.02% 91% -0.03%
==========================================
Files 143 143
Lines 49416 49396 -20
==========================================
- Hits 44981 44951 -30
- Misses 4435 4445 +10
Continue to review full report at Codecov.
|
gfyoung
force-pushed
the
create-last-kw-drop
branch
from
f4b329d
to
19998be
Compare
pandas/core/groupby.py
Outdated
| @Appender(Series.nlargest.__doc__) | ||
| def nlargest(self, n=5, keep='first'): | ||
| # ToDo: When we remove deprecate_kwargs, we can remote these methods | ||
| # TODO: When we remove deprecate_kwargs, we can remove these methods | ||
| # and include nlargest and nsmallest to _series_apply_whitelist |
There was a problem hiding this comment.
Ah yes, I should think so. Will do.
There was a problem hiding this comment.
lgtm otherwise. ping when ready.
gfyoung
force-pushed
the
create-last-kw-drop
branch
from
19998be
to
8997613
Compare
| _series_apply_whitelist = \ | ||
| (_common_apply_whitelist - set(['boxplot'])) | \ | ||
| frozenset(['dtype', 'unique']) | ||
| _series_apply_whitelist = ((_common_apply_whitelist | |
There was a problem hiding this comment.
should you actully just add them to the _common_apply_whitelist?
There was a problem hiding this comment.
Possibly, but what would it mean though in the context of a DataFrame?
There was a problem hiding this comment.
oh these are not defined on DataFrame, ok then.
|
Separate issue: why did so many Travis builds get canceled (including my most recent one)? |
|
fixing travis so hold a bit to repush |
|
caching wasn't working for miniconda. turned it back on, then then found an error, fixed it, which led to the next one......soon. |
|
ok pull and try again. I think its fixed :> |
gfyoung
force-pushed
the
create-last-kw-drop
branch
from
8997613
to
c72cffe
Compare
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-devgh-10236, pandas-devgh-10792, pandas-devgh-10920.
gfyoung
force-pushed
the
create-last-kw-drop
branch
from
c72cffe
to
b416290
Compare
|
lgtm. ping on green. |
|
thanks! keep em coming! |
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920. Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits: b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
Affected methods: 1) nlargest 2) nsmallest 3) duplicated 4) drop_duplicates xref pandas-dev#10236, pandas-dev#10792, pandas-dev#10920. Author: gfyoung <gfyoung17@gmail.com> Closes pandas-dev#15710 from gfyoung/create-last-kw-drop and squashes the following commits: b416290 [gfyoung] MAINT: Drop take_last kwarg from method signatures
Affected methods:
nlargestnsmallestduplicateddrop_duplicatesxref #10236, #10792, #10920.