Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: partial indexing with __getitem__ and integer labels #16029

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

toobaz
Copy link
Member

@toobaz toobaz commented Apr 17, 2017

Just a test for the bug, which was fixed at some time in the past.

@codecov
Copy link

codecov bot commented Apr 17, 2017

Codecov Report

Merging #16029 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16029   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         153      153           
  Lines       50469    50469           
=======================================
  Hits        45924    45924           
  Misses       4545     4545
Flag Coverage Δ
#multiple 88.76% <ø> (ø) ⬆️
#single 40.43% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90dd3f9...dcc5acd. Read the comment docs.

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Testing pandas testing functions or related to the test suite labels Apr 17, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 17, 2017
@jreback
Copy link
Contributor

jreback commented Apr 17, 2017

still reviewing.

@jorisvandenbossche
Copy link
Member

@toobaz Can you add the df[[1]] raising a KeyError case as well? (that also was incorrect at the time you opened the issue)

@toobaz
Copy link
Member Author

toobaz commented Apr 17, 2017

@toobaz Can you add the df[[1]] raising a KeyError case as well? (that also was incorrect at the time you opened the issue)

yep, done

@jorisvandenbossche jorisvandenbossche merged commit e0cbc37 into pandas-dev:master Apr 17, 2017
@jorisvandenbossche
Copy link
Member

@toobaz Thanks!

@toobaz toobaz deleted the test_partial_getitem branch April 17, 2017 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong behaviour/error when indexing MultiIndex with list
3 participants