New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Accept list-like color with single col in plot #16233

Merged
merged 1 commit into from May 11, 2017

Conversation

Projects
None yet
2 participants
@TomAugspurger
Contributor

TomAugspurger commented May 4, 2017

Close #3486

@TomAugspurger TomAugspurger added this to the 0.20.1 milestone May 4, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot May 4, 2017

Codecov Report

Merging #16233 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16233      +/-   ##
==========================================
- Coverage   90.39%   90.37%   -0.02%     
==========================================
  Files         161      161              
  Lines       50863    50863              
==========================================
- Hits        45977    45968       -9     
- Misses       4886     4895       +9
Flag Coverage Δ
#multiple 88.16% <100%> (ø) ⬆️
#single 40.33% <0%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_core.py 81.87% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc2185...7980460. Read the comment docs.

codecov bot commented May 4, 2017

Codecov Report

Merging #16233 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16233      +/-   ##
==========================================
- Coverage   90.39%   90.37%   -0.02%     
==========================================
  Files         161      161              
  Lines       50863    50863              
==========================================
- Hits        45977    45968       -9     
- Misses       4886     4895       +9
Flag Coverage Δ
#multiple 88.16% <100%> (ø) ⬆️
#single 40.33% <0%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/plotting/_core.py 81.87% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.59% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc2185...7980460. Read the comment docs.

@jreback jreback modified the milestone: 0.20.1 May 5, 2017

@TomAugspurger TomAugspurger merged commit 1bee035 into pandas-dev:master May 11, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 50%)
Details
codecov/project 90.37% (target 82%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TomAugspurger TomAugspurger modified the milestones: 0.21.0, 0.20.2 May 11, 2017

pcluo added a commit to pcluo/pandas that referenced this pull request May 22, 2017

@TomAugspurger TomAugspurger deleted the TomAugspurger:single-column-color branch May 27, 2017

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request May 29, 2017

TomAugspurger added a commit that referenced this pull request May 30, 2017

stangirala added a commit to stangirala/pandas that referenced this pull request Jun 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment