Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Add tests for sparse quantile/where #17568

Merged
merged 1 commit into from Oct 31, 2017
Merged

TST: Add tests for sparse quantile/where #17568

merged 1 commit into from Oct 31, 2017

Conversation

Licht-T
Copy link
Contributor

@Licht-T Licht-T commented Sep 18, 2017 •
edited

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This is the part of #17386.

jreback
jreback reviewed Sep 18, 2017
View reviewed changes
pandas/tests/sparse/test_frame.py Outdated
@pytest.mark.xfail(reason='Wrong SparseBlock initialization '
'(GH 17386)')
def test_where_with_int_data_and_bool_other(self):
# GH 17386
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls pls pls use parametrize. you are repeating way too many things

@codecov
Copy link

codecov bot commented Sep 18, 2017

Codecov Report

Merging #17568 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17568      +/-   ##
==========================================
+ Coverage   91.22%   91.25%   +0.02%     
==========================================
  Files         163      163              
  Lines       49624    49624              
==========================================
+ Hits        45269    45282      +13     
+ Misses       4355     4342      -13
Flag Coverage Δ
#multiple 89.03% <ø> (+0.04%) ⬆️
#single 40.19% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️
pandas/core/dtypes/cast.py 88% <0%> (+0.18%) ⬆️
pandas/core/internals.py 94.48% <0%> (+0.18%) ⬆️
pandas/core/sparse/array.py 92.27% <0%> (+0.96%) ⬆️
pandas/plotting/_converter.py 65.05% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb090f...b5e3b50. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 18, 2017 •
edited

Codecov Report

Merging #17568 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17568      +/-   ##
==========================================
+ Coverage   91.24%   91.25%   +0.01%     
==========================================
  Files         163      163              
  Lines       50091    50091              
==========================================
+ Hits        45704    45711       +7     
+ Misses       4387     4380       -7
Flag Coverage Δ
#multiple 100% <ø> (+10.96%) ⬆️
#single 40.25% <ø> (-0.06%) ⬇️
Impacted Files Coverage Δ
pandas/io/sas/sas_constants.py 100% <0%> (ø) ⬆️
pandas/parser.py 100% <0%> (ø) ⬆️
pandas/tools/hashing.py 100% <0%> (ø) ⬆️
pandas/lib.py 100% <0%> (ø) ⬆️
pandas/tslib.py 100% <0%> (ø) ⬆️
pandas/types/concat.py 100% <0%> (ø) ⬆️
pandas/io/json/json.py 100% <0%> (ø) ⬆️
pandas/io/formats/style.py 100% <0%> (ø) ⬆️
pandas/io/sas/sas7bdat.py 90.76% <0%> (ø) ⬆️
pandas/io/sas/sas_xport.py 90.27% <0%> (ø) ⬆️
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5959ee3...6af4266. Read the comment docs.

@Licht-T
Copy link
Contributor Author

Licht-T commented Sep 18, 2017

@jreback Thanks for your review. Parametrized other.

jreback
jreback requested changes Sep 18, 2017
View reviewed changes
pandas/tests/sparse/test_frame.py Outdated
@@ -1385,3 +1385,209 @@ def test_numpy_func_call(self):
'std', 'min', 'max']
for func in funcs:
getattr(np, func)(self.frame)

@pytest.mark.xfail(reason='Wrong SparseBlock initialization '
'(GH 17386)')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to parameterize on the data itself as well

@jreback jreback added the Sparse Sparse Data Type label Sep 18, 2017
@Licht-T
Copy link
Contributor Author

Licht-T commented Sep 18, 2017

@jreback Parametrized data.

@jreback
Copy link
Contributor

jreback commented Oct 28, 2017

can you rebase

@Licht-T Licht-T force-pushed the wrong-sparseblock-initialization branch from 6a1efaa to 3714bff Compare October 28, 2017 14:23
@Licht-T
Copy link
Contributor Author

Licht-T commented Oct 28, 2017

@jreback Rebased.

@jreback
Copy link
Contributor

jreback commented Oct 28, 2017

these tests are failing the CI, not really sure why

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 28, 2017
@Licht-T
Copy link
Contributor Author

Licht-T commented Oct 29, 2017

@jreback Okay. I'll check.

@Licht-T Licht-T force-pushed the wrong-sparseblock-initialization branch from 3714bff to 6af4266 Compare October 29, 2017 00:42
@Licht-T
Copy link
Contributor Author

Licht-T commented Oct 29, 2017 •
edited

@jreback It seems that segfault happened in test_where_with_bool_data_and_other.
Marked skip.
https://github.com/pandas-dev/pandas/pull/17568/files#diff-49bcacdc5f10a302e7cd6acb3ab0006aR1509

@jreback jreback added this to the 0.22.0 milestone Oct 31, 2017
@jreback jreback merged commit c65a0f5 into pandas-dev:master Oct 31, 2017
@jreback
Copy link
Contributor

jreback commented Oct 31, 2017

thanks @Licht-T

love to have the fixes for these!

peterpanmj pushed a commit to peterpanmj/pandas that referenced this pull request Oct 31, 2017
@Licht-T @peterpanmj
TST: Add tests for sparse quantile/where (pandas-dev#17568)
e192761
No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
@Licht-T @No-Stream
TST: Add tests for sparse quantile/where (pandas-dev#17568)
667e59f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Sparse Sparse Data Type Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Licht-T @jreback