CLN: Drop compact_ints/use_unsigned from read_csv #18851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All is green. Anyone welcome to have a look to merge this. |
|
wait on merging anything |
|
Ah, right. Travis is still failing. Got it. |
jreback
requested changes
Dec 20, 2017
| @@ -1569,11 +1544,6 @@ def _convert_to_ndarrays(self, dct, na_values, na_fvalues, verbose=False, | |||
| if cast_type and not is_dtype_equal(cvals, cast_type): | |||
| cvals = self._cast_types(cvals, cast_type, c) | |||
|
|
|||
| if issubclass(cvals.dtype.type, np.integer) and self.compact_ints: | |||
There was a problem hiding this comment.
I believe we can also blow away lib.downcast_int64, to_numeric uses a different (and better) mechanism for doing this. IIRC downcast_int64 was only for compatibility.
There was a problem hiding this comment.
GitHub search seems to verify that belief.
Deprecated in v0.19.0 xref pandas-devgh-13323
It was only being used for the compact_ints and use_unsigned parameters in read_csv.
gfyoung
force-pushed
the
compact-unsigned-remove
branch
from
efea2fb
to
74516a8
Compare
|
Function removed, and all is green still. PTAL. |
jreback
approved these changes
Dec 21, 2017
|
thanks @gfyoung |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in v0.19.0
xref #13323