BUG: show time values in repr of high precision DatetimeIndex #19109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 6, 2018
| @@ -883,6 +883,20 @@ def test_datetimelike_frame(self): | |||
| '[10 rows x 2 columns]') | |||
| assert repr(df) == expected | |||
|
|
|||
| def test_datetimeindex_highprecision(self): | |||
There was a problem hiding this comment.
see if you can parametrize this checking each digit of precision
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -374,7 +374,8 @@ Conversion | |||
| - Bug in :class:`TimedeltaIndex` where division by a ``Series`` would return a ``TimedeltaIndex`` instead of a ``Series`` (issue:`19042`) | |||
| - Bug in :class:`Series` with ``dtype='timedelta64[ns]`` where addition or subtraction of ``TimedeltaIndex`` could return a ``Series`` with an incorrect name (issue:`19043`) | |||
| - Fixed bug where comparing :class:`DatetimeIndex` failed to raise ``TypeError`` when attempting to compare timezone-aware and timezone-naive datetimelike objects (:issue:`18162`) | |||
| - | |||
| - Bug in :class:`DatetimeIndex` where the repr was not showing the time values for the end of the day (:issue:`19030`) | |||
Codecov Report
@@ Coverage Diff @@
## master #19109 +/- ##
==========================================
+ Coverage 91.51% 91.53% +0.02%
==========================================
Files 148 148
Lines 48753 48753
==========================================
+ Hits 44616 44628 +12
+ Misses 4137 4125 -12
Continue to review full report at Codecov.
|
reidy-p
force-pushed
the
datetimeindex_repr
branch
from
338c441
to
055e0ac
Compare
|
Hello @reidy-p! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on January 07, 2018 at 12:38 Hours UTC |
jreback
approved these changes
Jan 7, 2018
|
thanks @reidy-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffOn master:
On my branch:
It seems that it's only a problem when the time value was 23:59:59.999999999 or very similar, but I may need to add some more tests to check this further.