DEPR: Removing previously deprecated Categorical.labels (#6581) #19120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jan 7, 2018
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -314,6 +314,7 @@ Removal of prior version deprecations/changes | |||
| - The ``Panel4D`` and ``PanelND`` classes have been removed (:issue:`13776`) | |||
| - The ``Panel``class has dropped the ``to_long``and ``toLong`` methods (:issue:`19077`) | |||
| - The options ``display.line_with`` and ``display.height`` are removed in favor of ``display.width`` and ``display.max_rows`` respectively (:issue:`4391`, :issue:`19107`) | |||
| - The ``labels`` attribute of the ``Categorical`` class has been drop in favor of ``codes`` | |||
There was a problem hiding this comment.
drop -> removed
Categorical.labels in favor of :attribute`Categorical.codes`
add the issue number, the original if you can dig it up and this one
There was a problem hiding this comment.
Thanks for the comments! There is not issue related to deprecating or removing labels. The commits didn't reference any, and searching in the issue tracker didn't find anything either. I guess by "this one" you mean #6581, right? I updated the PR with it.
There was a problem hiding this comment.
no I dont mean #6581 I mean the issue / PR where it was originally deprecated. Yes its a commit hash, but more useful is a specific PR.
jreback
added
Categorical
jreback
requested changes
Jan 7, 2018
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -314,6 +314,7 @@ Removal of prior version deprecations/changes | |||
| - The ``Panel4D`` and ``PanelND`` classes have been removed (:issue:`13776`) | |||
| - The ``Panel``class has dropped the ``to_long``and ``toLong`` methods (:issue:`19077`) | |||
| - The options ``display.line_with`` and ``display.height`` are removed in favor of ``display.width`` and ``display.max_rows`` respectively (:issue:`4391`, :issue:`19107`) | |||
| - The ``labels`` attribute of the ``Categorical`` class has been removed in favor of attribute:`Categorical.codes` (:issue:`6581`) | |||
There was a problem hiding this comment.
use: :attribute:`Categorical.codes`
jreback
approved these changes
Jan 10, 2018
|
thanks! |
maximveksler
pushed a commit
to maximveksler/pandas
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff