DEPR: Removing previously deprecated flavor parameter from SQLiteData… #19121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Deprecate
jreback
requested changes
Jan 7, 2018
doc/source/whatsnew/v0.23.0.txt
Outdated
| @@ -314,6 +314,7 @@ Removal of prior version deprecations/changes | |||
| - The ``Panel4D`` and ``PanelND`` classes have been removed (:issue:`13776`) | |||
| - The ``Panel``class has dropped the ``to_long``and ``toLong`` methods (:issue:`19077`) | |||
| - The options ``display.line_with`` and ``display.height`` are removed in favor of ``display.width`` and ``display.max_rows`` respectively (:issue:`4391`, :issue:`19107`) | |||
| - The ``flavor`` parameter have been removed from ``SQLiteDatabase`` and :func:`to_sql` method | |||
There was a problem hiding this comment.
just say to_sql, SQLiteDatabase is not public. add the issue number and this issue.
|
hmm, these are not building on travis for some reason. |
|
It's a great reason for you to take a break today, it's Sunday! ;) |
jreback
approved these changes
Jan 10, 2018
|
thanks! |
maximveksler
pushed a commit
to maximveksler/pandas
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…base (#6581)
git diff upstream/master -u -- "*.py" | flake8 --diff