Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and test TimedeltaIndex.__rfloordiv__ bug #19125

Merged
merged 2 commits into from Jan 7, 2018

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jan 7, 2018

I thought we were ready to get rid of _TimeOp, but doing so turned up a couple of new bugs.

Setup:

scalar_td = pd.Timedelta('10m7s')
tdi = TimedeltaIndex(['00:05:03', '00:05:03', pd.NaT], freq=None)

Before:

>>> tdi.__rfloordiv__(scalar_td)
Float64Index([0.0, 0.0, nan], dtype='float64')

After:

>>> tdi.__rfloordiv__(scalar_td)
Float64Index([2.0, 2.0, nan], dtype='float64')
  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Jan 7, 2018

Codecov Report

Merging #19125 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19125      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.02%     
==========================================
  Files         148      148              
  Lines       48777    48780       +3     
==========================================
+ Hits        44636    44651      +15     
+ Misses       4141     4129      -12
Flag Coverage Δ
#multiple 89.9% <100%> (+0.02%) ⬆️
#single 41.59% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/base.py 96.45% <100%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 90.63% <100%> (+0.05%) ⬆️
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1265f66...d76237b. Read the comment docs.

@jreback jreback added Bug Timedelta Timedelta data type labels Jan 7, 2018
@jreback jreback added this to the 0.23.0 milestone Jan 7, 2018
@jreback jreback merged commit f6c0f8a into pandas-dev:master Jan 7, 2018
@jreback
Copy link
Contributor

jreback commented Jan 7, 2018

thanks!

@jbrockmendel jbrockmendel deleted the fix_tdi_rfloordiv branch January 7, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants