clarify redirection in ops #19346
clarify redirection in ops #19346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19346 +/- ##
==========================================
+ Coverage 91.57% 91.58% +0.01%
==========================================
Files 150 150
Lines 48702 48711 +9
==========================================
+ Hits 44597 44611 +14
+ Misses 4105 4100 -5
Continue to review full report at Codecov.
|
gfyoung
added
Internals
pandas/core/ops.py
Outdated
| equiv = typ + ' ' + op_desc['op'] + ' other' | ||
|
|
||
| if typ == 'series': | ||
| doc = _flex_doc_SERIES % (op_desc['desc'], op_name, equiv, |
There was a problem hiding this comment.
Will do. While I'm at it I'm going to bring the Panel docstring over here too and put the docstring templates in a dedicated section of the file. Other than that nothing changing in the next push (other than addressing comments).
pandas/core/ops.py
Outdated
| Parameters | ||
| ---------- | ||
| op_name : str | ||
| typ : str |
pandas/core/ops.py
Outdated
| op_desc['reverse']) | ||
| elif typ == 'dataframe': | ||
| doc = _flex_doc_FRAME % (op_desc['desc'], op_name, equiv, | ||
| op_desc['reverse']) |
There was a problem hiding this comment.
else raise an AssertionError
pandas/core/ops.py
Outdated
| def _flex_comp_method_FRAME(op, name, str_rep=None, default_axis='columns', | ||
| masker=False): | ||
| def _flex_comp_method_FRAME(op, name, str_rep=None, default_axis='columns'): | ||
| # Masker unused for now |
There was a problem hiding this comment.
I think you removed masker elsewhere? remove the comment
pandas/core/ops.py
Outdated
| """ | ||
| Wrapper function for Series arithmetic operations, to avoid | ||
| code duplication. | ||
| """ | ||
| masker = _gen_eval_kwargs(name).get('masker', None) |
pandas/core/ops.py
Outdated
| ------- | ||
| eval_kwargs : dict | ||
|
|
||
|
|
It's a fill value used for Series comparisons. The only place it is used ATM is in _comp_method_SERIES, where it defaults to False and is passed as True for |
|
ping on green. I still have to check that the doc-strings are unchanged from previous though. |
|
ping |
|
thanks! |
core.ops involves a lot of redirection. This decreases some of that redirection (and some redundancy) by implementing functions that show the logic of how some of the args/kwargs are chosen. The goal is to make it so future debugging can be done without going through
func.im_func.func_closure[1].cell_contents.func_closure...git diff upstream/master -u -- "*.py" | flake8 --diff