Separate non-scalar tests from test_timestamps #19385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Jan 25, 2018
| ser[0] = pd.Timestamp('nat') | ||
| ser[3] = pd.Timestamp('nat') | ||
|
|
||
| ops = {'lt': 'gt', 'le': 'ge', 'eq': 'eq', 'ne': 'ne'} |
| check(ts.week, 1) | ||
| check(ts.daysinmonth, 31) | ||
|
|
||
| ts = Timestamp('2014-01-01 00:00:00+01:00') |
There was a problem hiding this comment.
note to separate & parametrize (the is_* ones)
| # GH 17354 | ||
| assert data.weekday_name == expected | ||
|
|
||
| @pytest.mark.parametrize('tz', [None, 'UTC', 'US/Eastern', 'Asia/Tokyo']) |
There was a problem hiding this comment.
note to use the tz fixture
Noted. |
Codecov Report
@@ Coverage Diff @@
## master #19385 +/- ##
==========================================
+ Coverage 91.57% 91.64% +0.06%
==========================================
Files 150 150
Lines 48684 48699 +15
==========================================
+ Hits 44583 44630 +47
+ Misses 4101 4069 -32
Continue to review full report at Codecov.
|
|
thanks. a PR to separate into submodules (comparisons, arithmetic, and ops) would be very helpful (hint to do next). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting DataFrame, Series, Index tests out of tests.scalars and organizing them better, should make it easier to go and parametrize some older tests, in particular arithmetic and comparisons.