BUG/PERF: Fixed IntervalIndex.nbytes and itemsize #20600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid materializing the ndarray of Intervals. Just get from left and right instead. Closes pandas-dev#19209
jreback
requested changes
Apr 4, 2018
|
|
||
| @property | ||
| def itemsize(self): | ||
| return self.left.itemsize + self.right.itemsize |
There was a problem hiding this comment.
this doesn’t really make sense to have
why do u need this?
| @@ -24,6 +24,7 @@ def name(request): | |||
|
|
|||
| class TestIntervalIndex(Base): | |||
| _holder = IntervalIndex | |||
| _compat_props = ['shape', 'ndim', 'size'] | |||
There was a problem hiding this comment.
what is this for? we don’t use it anywhere
Codecov Report
@@ Coverage Diff @@
## master #20600 +/- ##
==========================================
+ Coverage 91.84% 91.84% +<.01%
==========================================
Files 153 153
Lines 49256 49260 +4
==========================================
+ Hits 45241 45245 +4
Misses 4015 4015
Continue to review full report at Codecov.
|
|
Sorry, was just using this to demo stuff for a talk on OSS I gave last night. I think this will be solved by Interval being an ExtensionArray (should have that PR today). |
|
Closing in favor of #20611. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid materializing the ndarray of Intervals. Just get from left and right
instead.
Closes #19209