Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/DEPR: deprecate Categorical take default behaviour + fix Series[categorical].take #20841

Merged
merged 12 commits into from
Apr 30, 2018

Commits on Apr 27, 2018

  1. Squashed commit of the following:

    commit ec0cecd
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Fri Apr 27 06:02:48 2018 -0500
    
        Updates
    
    commit 6858409
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Fri Apr 27 05:48:59 2018 -0500
    
        Added note
    
    commit eb43fa4
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 20:47:35 2018 -0500
    
        Really truly fix it hopefully.
    
    commit 7c4f625
    Merge: 9a6c7d4 6cacdde
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 20:40:15 2018 -0500
    
        Merge remote-tracking branch 'upstream/master' into ea-take
    
    commit 9a6c7d4
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 20:04:17 2018 -0500
    
        Doc updates
    
    commit eecd632
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 15:00:00 2018 -0500
    
        Skip categorical take tests
    
    commit f3b91ca
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 13:43:26 2018 -0500
    
        doc fixup
    
    commit fbc4425
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 13:37:45 2018 -0500
    
        Updates
    
        * indexer -> indices
        * doc user-facing vs physical
        * assert na_cmps
        * test reindex w/ non-NA fill_value
    
    commit 741f284
    Merge: 5db6624 630ef16
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 07:18:32 2018 -0500
    
        Merge remote-tracking branch 'upstream/master' into ea-take
    
    commit 5db6624
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Thu Apr 26 07:17:30 2018 -0500
    
        Doc and move tests
    
    commit 74b2c09
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 21:40:18 2018 -0500
    
        Added verisonadded
    
    commit fc729d6
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 15:51:27 2018 -0500
    
        Fixed editor
    
    commit 1a4d987
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 15:50:48 2018 -0500
    
        Pass an array
    
    commit bbcbf19
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 15:07:28 2018 -0500
    
        Cleanup
    
    commit d5470a0
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 15:02:26 2018 -0500
    
        Fixed reorder
    
    commit 82cad8b
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 15:00:43 2018 -0500
    
        Stale comment
    
    commit c449afd
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 14:48:33 2018 -0500
    
        Bounds checking
    
    commit 449983b
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 12:55:31 2018 -0500
    
        Linting
    
    commit 69e7fe7
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 12:40:20 2018 -0500
    
        Updates
    
        1. Reversed order of take keywords
        2. Added to extensions API
        3. Removed default implementation
    
    commit 05d8844
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 09:59:33 2018 -0500
    
        Updated docs
    
    commit 31cd304
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 09:43:45 2018 -0500
    
        pep8
    
    commit 338566f
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 09:42:28 2018 -0500
    
        Upcasting
    
    commit b7ae0bc
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 09:06:59 2018 -0500
    
        revert combine change
    
    commit 125ca0b
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 08:37:07 2018 -0500
    
        Simplify
    
        Upcasting is still broken
    
    commit c721915
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 07:50:54 2018 -0500
    
        Removed default_fill_value
    
    commit 37915e9
    Merge: 67ba9dd 60fe82c
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 07:44:15 2018 -0500
    
        Merge remote-tracking branch 'upstream/master' into ea-take
    
    commit 67ba9dd
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 07:42:54 2018 -0500
    
        more with default fill value
    
    commit eba137f
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 05:59:58 2018 -0500
    
        More internals hacking
    
    commit 08f2479
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Wed Apr 25 05:59:17 2018 -0500
    
        Fixup JSON take
    
    commit 0be9ec6
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Tue Apr 24 18:02:13 2018 -0500
    
        non-internals changes
    
    commit dacd98e
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Tue Apr 24 14:45:36 2018 -0500
    
        Moves
    
    commit fb3c234
    Author: Tom Augspurger <tom.w.augspurger@gmail.com>
    Date:   Tue Apr 24 13:59:51 2018 -0500
    
        [WIP]: ExtensionArray.take default implementation
    
        Implements a take interface that's compatible with NumPy and optionally pandas'
        NA semantics.
    
        ```python
        In [1]: import pandas as pd
    
        In [2]: from pandas.tests.extension.decimal.array import *
    
        In [3]: arr = DecimalArray(['1.1', '1.2', '1.3'])
    
        In [4]: arr.take([0, 1, -1])
        Out[4]: DecimalArray(array(['1.1', '1.2', '1.3'], dtype=object))
    
        In [5]: arr.take([0, 1, -1], fill_value=float('nan'))
        Out[5]: DecimalArray(array(['1.1', '1.2', Decimal('NaN')], dtype=object))
        ```
    
        Closes pandas-dev#20640
    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    644138f View commit details
    Browse the repository at this point in the history
  2. BUG/API: FutureWarning from Categorical.take indices

    We're changing how Categorical.take handles negative indices to be in
    line with Series and other EAs.
    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    b874eed View commit details
    Browse the repository at this point in the history
  3. Linting

    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    07a561c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aa7266c View commit details
    Browse the repository at this point in the history
  5. Updates

    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    3a98ede View commit details
    Browse the repository at this point in the history
  6. Clarified comment

    TomAugspurger committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    69701f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2018

  1. Configuration menu
    Copy the full SHA
    f777fa1 View commit details
    Browse the repository at this point in the history
  2. Actually use data

    TomAugspurger committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    d1c7e38 View commit details
    Browse the repository at this point in the history
  3. typo

    jorisvandenbossche committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    6056f7a View commit details
    Browse the repository at this point in the history
  4. update

    TomAugspurger committed Apr 28, 2018
    Configuration menu
    Copy the full SHA
    f7e0e6d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    635db4f View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2018

  1. Moved to deprecations

    TomAugspurger committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    12485c5 View commit details
    Browse the repository at this point in the history