-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG/DEPR: deprecate Categorical take default behaviour + fix Series[categorical].take #20841
Merged
jorisvandenbossche
merged 12 commits into
pandas-dev:master
from
TomAugspurger:categorical-take
Apr 30, 2018
Merged
BUG/DEPR: deprecate Categorical take default behaviour + fix Series[categorical].take #20841
jorisvandenbossche
merged 12 commits into
pandas-dev:master
from
TomAugspurger:categorical-take
Apr 30, 2018
Commits on Apr 27, 2018
-
Squashed commit of the following:
commit ec0cecd Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Fri Apr 27 06:02:48 2018 -0500 Updates commit 6858409 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Fri Apr 27 05:48:59 2018 -0500 Added note commit eb43fa4 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 20:47:35 2018 -0500 Really truly fix it hopefully. commit 7c4f625 Merge: 9a6c7d4 6cacdde Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 20:40:15 2018 -0500 Merge remote-tracking branch 'upstream/master' into ea-take commit 9a6c7d4 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 20:04:17 2018 -0500 Doc updates commit eecd632 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 15:00:00 2018 -0500 Skip categorical take tests commit f3b91ca Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 13:43:26 2018 -0500 doc fixup commit fbc4425 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 13:37:45 2018 -0500 Updates * indexer -> indices * doc user-facing vs physical * assert na_cmps * test reindex w/ non-NA fill_value commit 741f284 Merge: 5db6624 630ef16 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 07:18:32 2018 -0500 Merge remote-tracking branch 'upstream/master' into ea-take commit 5db6624 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Thu Apr 26 07:17:30 2018 -0500 Doc and move tests commit 74b2c09 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 21:40:18 2018 -0500 Added verisonadded commit fc729d6 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 15:51:27 2018 -0500 Fixed editor commit 1a4d987 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 15:50:48 2018 -0500 Pass an array commit bbcbf19 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 15:07:28 2018 -0500 Cleanup commit d5470a0 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 15:02:26 2018 -0500 Fixed reorder commit 82cad8b Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 15:00:43 2018 -0500 Stale comment commit c449afd Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 14:48:33 2018 -0500 Bounds checking commit 449983b Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 12:55:31 2018 -0500 Linting commit 69e7fe7 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 12:40:20 2018 -0500 Updates 1. Reversed order of take keywords 2. Added to extensions API 3. Removed default implementation commit 05d8844 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 09:59:33 2018 -0500 Updated docs commit 31cd304 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 09:43:45 2018 -0500 pep8 commit 338566f Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 09:42:28 2018 -0500 Upcasting commit b7ae0bc Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 09:06:59 2018 -0500 revert combine change commit 125ca0b Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 08:37:07 2018 -0500 Simplify Upcasting is still broken commit c721915 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 07:50:54 2018 -0500 Removed default_fill_value commit 37915e9 Merge: 67ba9dd 60fe82c Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 07:44:15 2018 -0500 Merge remote-tracking branch 'upstream/master' into ea-take commit 67ba9dd Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 07:42:54 2018 -0500 more with default fill value commit eba137f Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 05:59:58 2018 -0500 More internals hacking commit 08f2479 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Wed Apr 25 05:59:17 2018 -0500 Fixup JSON take commit 0be9ec6 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Tue Apr 24 18:02:13 2018 -0500 non-internals changes commit dacd98e Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Tue Apr 24 14:45:36 2018 -0500 Moves commit fb3c234 Author: Tom Augspurger <tom.w.augspurger@gmail.com> Date: Tue Apr 24 13:59:51 2018 -0500 [WIP]: ExtensionArray.take default implementation Implements a take interface that's compatible with NumPy and optionally pandas' NA semantics. ```python In [1]: import pandas as pd In [2]: from pandas.tests.extension.decimal.array import * In [3]: arr = DecimalArray(['1.1', '1.2', '1.3']) In [4]: arr.take([0, 1, -1]) Out[4]: DecimalArray(array(['1.1', '1.2', '1.3'], dtype=object)) In [5]: arr.take([0, 1, -1], fill_value=float('nan')) Out[5]: DecimalArray(array(['1.1', '1.2', Decimal('NaN')], dtype=object)) ``` Closes pandas-dev#20640
Configuration menu - View commit details
-
Copy full SHA for 644138f - Browse repository at this point
Copy the full SHA 644138fView commit details -
BUG/API: FutureWarning from Categorical.take indices
We're changing how Categorical.take handles negative indices to be in line with Series and other EAs.
Configuration menu - View commit details
-
Copy full SHA for b874eed - Browse repository at this point
Copy the full SHA b874eedView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07a561c - Browse repository at this point
Copy the full SHA 07a561cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa7266c - Browse repository at this point
Copy the full SHA aa7266cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a98ede - Browse repository at this point
Copy the full SHA 3a98edeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 69701f2 - Browse repository at this point
Copy the full SHA 69701f2View commit details
Commits on Apr 28, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f777fa1 - Browse repository at this point
Copy the full SHA f777fa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1c7e38 - Browse repository at this point
Copy the full SHA d1c7e38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6056f7a - Browse repository at this point
Copy the full SHA 6056f7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7e0e6d - Browse repository at this point
Copy the full SHA f7e0e6dView commit details -
Merge branch 'categorical-take' of https://github.com/TomAugspurger/p…
…andas into categorical-take
Configuration menu - View commit details
-
Copy full SHA for 635db4f - Browse repository at this point
Copy the full SHA 635db4fView commit details
Commits on Apr 30, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 12485c5 - Browse repository at this point
Copy the full SHA 12485c5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.