BUG: Categorical.fillna with iterables #21215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
added
Missing-data
Codecov Report
@@ Coverage Diff @@
## master #21215 +/- ##
==========================================
+ Coverage 91.84% 91.84% +<.01%
==========================================
Files 153 153
Lines 49505 49506 +1
==========================================
+ Hits 45466 45467 +1
Misses 4039 4039
Continue to review full report at Codecov.
|
jorisvandenbossche
approved these changes
May 26, 2018
|
thanks @TomAugspurger |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Jun 8, 2018
Closes pandas-dev#19788 Closes pandas-dev#21097 (cherry picked from commit 36c1f6b)
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jun 9, 2018
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19788
Closes #21097
Note that
Series.fillnastill doesn't allow iterables. I'm not sure that we should allow that, as it's potentially confusing what that would do.