Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Unchanged arith methods to EA mixins #21712

Merged
merged 3 commits into from
Jul 3, 2018

Conversation

jbrockmendel
Copy link
Member

Next steps after #19902. Breaking these up into smaller pieces than usual because I don't know what bits will prove controversial.

All this PR does is take a few of the easiest no-changes-needed methods and moved them to the EA mixins.

@jbrockmendel jbrockmendel changed the title Dtarrays4 Move Unchanged arith methods to EA mixins Jul 3, 2018
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #21712 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21712      +/-   ##
==========================================
+ Coverage    91.9%   91.91%   +<.01%     
==========================================
  Files         158      158              
  Lines       49690    49689       -1     
==========================================
+ Hits        45670    45671       +1     
+ Misses       4020     4018       -2
Flag Coverage Δ
#multiple 90.28% <100%> (ø) ⬆️
#single 41.95% <43.75%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/period.py 92.55% <ø> (-0.04%) ⬇️
pandas/core/indexes/datetimelike.py 96.87% <ø> (+0.15%) ⬆️
pandas/core/indexes/timedeltas.py 91.08% <ø> (-0.11%) ⬇️
pandas/core/arrays/datetimelike.py 94.52% <100%> (+1.76%) ⬆️
pandas/core/arrays/period.py 100% <100%> (ø) ⬆️
pandas/core/arrays/timedelta.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd2679...32e4269. Read the comment docs.

@gfyoung gfyoung added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Jul 3, 2018
@gfyoung gfyoung requested a review from jreback July 3, 2018 09:42
@jreback jreback added this to the 0.24.0 milestone Jul 3, 2018
@jreback
Copy link
Contributor

jreback commented Jul 3, 2018

lgtm. @TomAugspurger @jorisvandenbossche if any comments.

@jreback jreback merged commit 2b13605 into pandas-dev:master Jul 3, 2018
@jreback
Copy link
Contributor

jreback commented Jul 3, 2018

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the dtarrays4 branch July 6, 2018 14:37
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants